Cadasta / cadasta-platform

[DEPRECATED] Main repository of the Cadasta platform. Technology to help communities document their land rights around the world.
https://demo.cadasta.org
GNU Affero General Public License v3.0
54 stars 81 forks source link

Mobile Experience :: Disable Touch Zoom On Map When Editing #1127

Open SteadyCadence opened 7 years ago

SteadyCadence commented 7 years ago

Steps to reproduce the error

With your mobile phone, "Add location" on a project. Choose a polygon, rectangle or marker from the controls on the left of the map. Click or double click the map and the map zooms in instead of allows you to add a point.

screenshot_20170215-101821 1

Expected Behavior

When you try to place a place a point on the map, the map zooms in and out instead of allows you to add a point (related to another issue in leaflet). We decided it would be best to disable touch zoom while editing. The zoom controls are available on the left.

laura-barluzzi commented 7 years ago

Hi @dpalomino and @wonderchook, I'm interested in trying out to fix this bug. Could be possible to direct me to the source code of the mobile view at the "Add location" stage? Thanks.

oliverroick commented 7 years ago

I'm not sure if we should fix this issue at the moment. We are currently working on a complete rewrite of the maps area; it's probably better to have this sorted once the new implementation is ready.

SteadyCadence commented 7 years ago

Since this issue is on hold until the new map is released could we note that shrinking or moving the scale bar may also be required for a good mobile experience?

The scale bar prohibits users from clicking the "point" button on mobile.

SteadyCadence commented 7 years ago

I spoke with Frank this morning and a majority of his participants in Indonesia are using their mobile phones for data collection and admin work (review/editing). I think it is very important to enable users to collect data on the mobile/tablet phones. In other words, I am trying to bring attention to this issue as it is prohibiting users from collecting date on their mobile phones. :)

wonderchook commented 7 years ago

@SteadyCadence appreciate the feedback, we still can't really work on it until the refactoring is done. @clash99 we should think through how all the map interactions with on mobile to make sure it is possible. Then go through the list after the refactor and fix the ones that don't work.

dpalomino commented 7 years ago

To be tested after the SMAP work is completed.

SteadyCadence commented 7 years ago

FYI @linzjax @dpalomino @wonderchook I am still unable to add locations via mobile phone with smap.

SteadyCadence commented 7 years ago

Oh it looks like I can add a polygon (not a rectangle and its still super hard to add geometries to the map) but we need to disable the touch zoom.

dpalomino commented 7 years ago

Thanks @SteadyCadence.

I've been testing a bit with both a smartphone (mid-range Android device), and a tablet (low-end Android device). Some thoughts:

Maybe we can try to find some time to review user experience with mobile while in Madrid? There are some interesting cases where this would be very useful in the field.

I will test later on with a fancier tablet to see if there is a big difference.