search

Cadasta / cadasta-platform

[DEPRECATED] Main repository of the Cadasta platform. Technology to help communities document their land rights around the world.
https://demo.cadasta.org
GNU Affero General Public License v3.0
53 stars 81 forks source link

Maintenance: fix warnings, deprecations #1521

Open amplifi opened 7 years ago

amplifi commented 7 years ago

Follow-up task from PR #1520: There are still loads of warnings. Some can be resolved by upgrading libraries we use (pytest, django rest framework). We also need to update our own libraries: django-tutelary for example, which causes a lot of deprecation warnings.

Impact: Lack of maintenance updates to the platform code caused all Travis builds to fail for the main repo today. Regular upkeep is essential to reduce bugs, failures, and security vulnerabilities.

wonderchook commented 7 years ago

@amplifi what do you see as the best way to monitor that? Were these warnings always present and we ignored them? Or are they relatively new and we should have paid attention?

amplifi commented 7 years ago

@wonderchook The warnings have been present and ignored, so they've accumulated over many months of only fixing errors and not keeping packages up to date. When tests pass, the message displayed has been similar to:

================= 1873 passed, 829 warnings in 499.97 seconds ==================

We already use Requires.io for tracking dependencies via email alerts; I've also just enabled and configured their Pull Request option (the service will automatically create new PRs on our repos that bump package version based on a specified threshold). This will give us a more visible alert that packages have changed and show us right away whether or not our builds still pass, with how many errors/warnings.

But it's still a matter of actually checking the warnings and making the fixes where needed. This should be incorporated into the development workflow and PR approval process.