search

Cadasta / cadasta-qgis-plugin

[DEPRECATED] QGIS plugin to create, edit, upload and download Cadasta projects
GNU General Public License v3.0
4 stars 7 forks source link

Fix empty strings translated to None #184

Closed dimasciput closed 7 years ago

dimasciput commented 7 years ago

Fix #173

wonderchook commented 7 years ago

@dimasciput I tested out this pull request fix. It doesn't seem to work in cases where you have a text field with a data string in it. I've attached a sample

kate_made_geojson.zip

dimasciput commented 7 years ago

Thanks, I updated my PR. If you gave empty string for party name, the output will be like this :

screen shot 2017-04-28 at 12 35 53 pm
wonderchook commented 7 years ago

I haven't tested this yet, but I think you fixed a different issue. What I think is happening is when you have a string column but happen to have data in it that parses to a date e.g. 2007-01-01. Somehow this is causing an issue on upload.

dimasciput commented 7 years ago

I haven't tested this yet, but I think you fixed a different issue. What I think is happening is when you have a string column but happen to have data in it that parses to a date e.g. 2007-01-01. Somehow this is causing an issue on upload.

Well I managed to upload the project with no issue, here's a screenshot from cadasta site : screen shot 2017-05-02 at 10 50 18 am

wonderchook commented 7 years ago

Okay seems to be working now!