Cadiboo / NoCubes

A mod for 1.12.2+ that creates smooth terrain in Minecraft
https://Cadiboo.github.io/projects/nocubes/
GNU Lesser General Public License v3.0
140 stars 12 forks source link

Modded Block Render Bugs #27

Closed WenXin20 closed 5 years ago

WenXin20 commented 5 years ago

Forge v14.23.5.2810-1.12.2 No Cubes v0.2.6-pre1

I noticed that some mod blocks, when added to the config, display oddly. Are any of these able to be fixed?

Mubble Unstable Stone: Before & After: before-after unstable stone

Underground Biomes' Ores: 2019-03-04_18 55 10

Treasure 2's Ores: 2019-03-04_11 41 26

Puddle from the Puddles mod: 2019-03-04_17 30 32

Dynamic Trees Rooty Sand: 2019-03-03_13 52 20

Cadiboo commented 5 years ago

I don’t support having more than 1 texture (i.e. overlays) for a block yet, this will be fixed soon and at the same time as emissive quad support is added. I have no clue about dynamic trees roots. My assumption is that they’re using a TESR to render their roots, rather than a custom baked model. A TESR (TileEntity Special Renderer) is a renderer that directly renders everything each frame. A BakedModel is a model that is re-rendered by the minecraft chunk renderer every time a chunk changes. BakedModels simply provide a list of faces and textures, which NoCubes reads and renders itself. A TESR re-renders every frame so it can be much more dynamic than baked models. TESRs are also easier to code than a custom baked model, but are more performance intensive. Because a TESR renders everything itself, the block it’s rendering usually returns a missing texture/no texture from its baked model, as the baked model is normally never used. I’ll look at the dynamic trees code, but I think if I’m right and they are using a TESR, it’s a problem on their side.

WenXin20 commented 5 years ago

Ok, thanks. I can report it there if that's the case.

Jdewi12 commented 5 years ago

I don't think it's a bug on their side, rather just something that is unsupported by NoCubes (if I'm understanding right)

Cadiboo commented 5 years ago

Its not a bug per say, I think they're just doing stuff in an insupportable and needlessly performance intensive way. I haven't looked at their code yet though

jredfox commented 5 years ago

the normal rendering is due to non auto detection and your configuration settings not really no cubes itself. this also could be the same with liquid. As for missing textures and improper colors there might be an issue there but, only report one issue per report 99% of the time it's the proper way to do it

Cadiboo commented 5 years ago

1 is caused by NoCubes not rendering all the parts of the model (will be fixed soon:tm:) 2 probably the same as 1 3 possibly the same as 1 4 the same as 1 5 no clue wtf is wrong or what Dynamic Trees is doing, but I added explicit support for their rooty dirt and now everything works

non auto detection

Coming soon:tm:

only report one issue per report 99% of the time it's the proper way to do it

^

Cadiboo commented 5 years ago

Should be fixed in the latest pre-release