search

Cadiboo / NoCubes

A mod for 1.12.2+ that creates smooth terrain in Minecraft
https://Cadiboo.github.io/projects/nocubes/
GNU Lesser General Public License v3.0
140 stars 12 forks source link

NoCubes Crash #34

Closed SpeakerHornet closed 5 years ago

SpeakerHornet commented 5 years ago

Forge: 14.23.5.2796 NoCubes: 1.12.2-0.2.9-pre1 RenderChunk rebuildChunk hooks: 1.12.2-0.3.1

No additional mods.

Log: https://paste.ee/p/K4Puc

Cadiboo commented 5 years ago

NoCubes above 0.2.8 does not require RenderChunk rebuildChunk Hooks and is incompatible with it

SpeakerHornet commented 5 years ago

Oh ok, thanks!

Cadiboo commented 5 years ago

I’ll see if I can add something to the dependencies of my mod that will cause a nicer crash

SpeakerHornet commented 5 years ago

it crashes without render chunk rebuild chunk hooks now.

https://paste.ee/p/WNLmY

Cadiboo commented 5 years ago

Well... I’ll fix that soon, I only tested it with OptiFine and CTM installed. The ASM code is a bit fragile because I backported it directly from 1.13

Cadiboo commented 5 years ago

Should be fixed in the latest

MorePortal commented 5 years ago

I have the same issue with the latest NoCubes(1.12.2-0.2.10-pre5) and latest Forge (14.23.5.2838)

https://gist.github.com/MorePortal/3c987cbeca34ba1c678e550781eb04ac

Cadiboo commented 5 years ago

This has been fixed in dev and will be fixed in the next prerelease