Cadiboo / NoCubes

A mod for 1.12.2+ that creates smooth terrain in Minecraft
https://Cadiboo.github.io/projects/nocubes/
GNU Lesser General Public License v3.0
140 stars 12 forks source link

Smooth trees issue #75

Open dudebro9800 opened 4 years ago

dudebro9800 commented 4 years ago

Despite the smooth option being toggled on, the trees still arent smooth; theyre blocky

Cadiboo commented 4 years ago

Sorry for the late response, can you post your client & server config and a screenshot please?

dudebro9800 commented 4 years ago

Where can I locate my client and server config? I don't know what thiat is. 2020-06-20_19 36 02 2020-06-20_19 35 49

dudebro9800 commented 4 years ago

Sorry for the late response, can you post your client & server config and a screenshot please?

hewllo?

Cadiboo commented 4 years ago

Hey, sorry, been a while. Your client config will be in ".minecraft/config/nocubes-client.toml" and your server config will be in ".minecraft/saves/worldname/serverconfig/nocubes-server.toml". Please also share your latest.log from "[.minecraft](https://minecraft.gamepedia.com/.minecraft#Locating.minecraft)/logs/latest.log" and your debug.log (if it exists) from the same folder.

dudebro9800 commented 4 years ago

Screenshot (1) Screenshot (2) Screenshot (3)

hope this helps dude or dudette

dudebro9800 commented 4 years ago

Hey, sorry, been a while. Your client config will be in ".minecraft/config/nocubes-client.toml" and your server config will be in ".minecraft/saves/worldname/serverconfig/nocubes-server.toml". Please also share your latest.log from "[.minecraft](https://minecraft.gamepedia.com/.minecraft#Locating.minecraft)/logs/latest.log" and your debug.log (if it exists) from the same folder.

hello?

Cadiboo commented 4 years ago

Hey, really, really sorry that I've taken so long to help you with this.

You should just be able to change renderSmoothAndVanillaLeaves from "true" to "false" in your client config.

That option was added at someone else's request because it looked cool with their texture pack/shader.

It's taken so long to respond because:

I should have opened with this, but I'm a little bit more responsive on discord. Feel free to ping me on the nocubes server in #support or pm me @Cadiboo#8887.

dudebro9800 commented 4 years ago

im [disappointed.] Despite toggling that off, the trees are still blocky. they still got that circular shape but with cubes showing like months ago when i complained 2020-07-22_21 44 42 2020-07-22_21 44 53 2020-07-22_21 44 59 2020-07-22_21 45 02

Cadiboo commented 4 years ago

Could you please send your client config and logs again? The fact that you aren’t getting the same issue with your terrain means that it’s got to be caused by that config setting being true or a bug in the mod. You change the value in client config to true when the game isn’t open and it should work when you next open the game. If it doesn’t work when you next open the game, there should be something like “correcting incorrect config value renderSmoothAndVanillaLeaves” that should show the issue.

If that doesn’t work, please upload your client and server configs here and I’ll debug the issue on my own computer.

dudebro9800 commented 4 years ago

Screenshot (6) Problem solved. But now i have a new problem: lack of leafiness despite the foliage mod is on. I toggled that config like you told me after quitting the game and restarting. But the leafiness doesn't appear like when my trees were blocky before that advice u gave me Screenshot (6)

also how do i fix those purple thingies?

Cadiboo commented 4 years ago

Yeah, the extra foliage coming out from the sides of the leaves isn't in NoCubes, IIRC that's why the option to display both smooth and vanilla trees was added. NoCubes takes the texture from the side of the block and renders it bent, I'd have to write my own code to add that extra foliage (the way I've done with the short grass). This wouldn't be extremely hard, but I haven't done it yet. Trees have never really looked that good/real in NoCubes and fixing this would involve a lot of work and planning.

Cadiboo commented 4 years ago

Hey, I’m working on updating the mod to 1.16 currently. I’ve decided to rewrite the mod from the ground up. I’m also planning on backporting the rewrite 1.12.2. Since I’m doing this I have the opportunity to implement support for fancy leaves right into nocubes without the pain of having to rewrite large amounts of code. If you could describe what you would like the leafiness of the trees to look like I‘ll work on implementing it :).

The purple things have been fixed in 1.16 already.

dudebro9800 commented 4 years ago

Hey, I’m working on updating the mod to 1.16 currently. I’ve decided to rewrite the mod from the ground up. I’m also planning on backporting the rewrite 1.12.2. Since I’m doing this I have the opportunity to implement support for fancy leaves right into nocubes without the pain of having to rewrite large amounts of code. If you could describe what you would like the leafiness of the trees to look like I‘ll work on implementing it :).

The purple things have been fixed in 1.16 already.

Yes thank you but I don’t want to play Minecraft in 1.16. I’m stuck on 1.12 because some of my fav mods haven’t updated beyond 1.12 and my favorite texture pack is at 1.12.

In order to make the trees realistic, I use the foliage mod in conjunction with your mod . In spite of the foliage mod, the trees don’t look leafy while using your mod. If you notice in those pics from June 20 the trees were blocky and leafy — this was before I took your advice on how to un-blockify the leaves. And they’re leafy because of the foliage mod. Now, after your advice, the leaves are no longer blocky but smooth; but smooth and not leafy like how I wanted them to be

Cadiboo commented 4 years ago

Yes thank you but I don’t want to play Minecraft in 1.16.

I'm not asking you to.

I’m stuck on 1.12 because some of my fav mods haven’t updated beyond 1.12 and my favorite texture pack is at 1.12.

I understand this, 1.12.2 was my favourite version as well, that's why I said "I’m also planning on backporting the rewrite 1.12.2."

In order to make the trees realistic, I use the foliage mod in conjunction with your mod . In spite of the foliage mod, the trees don’t look leafy while using your mod.

Yeah, it's not possible for stuff like this to "just work" with the way NoCubes is written in 1.12.2. One of my goals in the rewrite is to make stuff more compatible. Another goal is to make stuff look and run better.

If you notice in those pics from June 20 the trees were blocky and leafy — this was before I took your advice on how to un-blockify the leaves. And they’re leafy because of the foliage mod. Now, after your advice, the leaves are no longer blocky but smooth; but smooth and not leafy like how I wanted them to be

You can change (back) your config, I've even created a config GUI for NoCubes. Your current options in 1.12.2 are:

By "the foliage mod" do you mean BetterFoliage? If so, BetterFoliage changes how leaves look in a performance degrading way that also cannot be compatible with NoCubes. I've previously talked with the author and they've told me that they intend to fix this in the future.

dudebro9800 commented 3 years ago

You done?

Cadiboo commented 3 years ago

With what?

dudebro9800 commented 3 years ago

With what?

what i wanted you to do

Cadiboo commented 3 years ago

I asked you what you wanted done

I’ve decided to rewrite the mod from the ground up. I’m also planning on backporting the rewrite to 1.12.2. Since I’m doing this I have the opportunity to implement support for fancy leaves right into nocubes without the pain of having to rewrite large amounts of code. If you could describe what you would like the leafiness of the trees to look like I‘ll work on implementing it :).

The purple things have been fixed in 1.16 already.

And you replied

Yes thank you but I don’t want to play Minecraft in 1.16. I’m stuck on 1.12 because some of my fav mods haven’t updated beyond 1.12 and my favorite texture pack is at 1.12.

So if you want me to implement leaves on trees as part of NoCubes then I’m still waiting for you to tell me what you’d like that to look like.

You also said

If you notice in those pics from June 20 the trees were blocky and leafy — this was before I took your advice on how to un-blockify the leaves. And they’re leafy because of the foliage mod. Now, after your advice, the leaves are no longer blocky but smooth; but smooth and not leafy like how I wanted them to be

And I said that you could have

  • Vanilla style leaves (+ whatever the Foliage mod adds)
  • Smoothed NoCubes style leaves AND Vanilla style leaves (+ whatever the Foliage mod adds)
  • Just smoothed NoCubes style leaves

I also asked if by “the Foliage mod” you meant BetterFoliage. I asked this because BetterFoliage changes everything in a way that cannot be compatible with NoCubes (they intercept blocks mod-rendering and add extra details right into the raw buffer data that will be rendered to your screen). If the mod is BetterFoliage I’ll need to implement the leaves from scratch myself the way I did with the short grass. If it’s not BetterFoliage I’ll happily look at how the extra leaves are added and try and add compatibility (I’ve done this before and the person thought that rendering them both at the same time would look good, so i added it).

dudebro9800 commented 3 years ago

it's better foliage

also i dont understand what your point is. you dont know what i want? all i want are the trees to not be blocky. i want them to look like realistic trees so i used your mod and better foliage but it didsnt come out looking. and when i dont use the foliage mod but only yours the trees look too smooth and not like real trees and i tried to counteract this by using better foliage but that didnt work.

Cadiboo commented 3 years ago

This can’t be done in the mod currently. I’ll look into a solution. This looks promising and I should be able to do it without too much trouble by rendering the part of the model that isn’t the cube’s sides for each leaf block after I’ve smoothed the tree. However, this won’t work with BetterFoliage because of how it does stuff. I think there’s a texture pack out there that does something similar though. I’ll keep this issue open until it’s fixed. It probably won’t be fixed soon though due to lack of free time.