Cadiboo / NoCubes

A mod for 1.12.2+ that creates smooth terrain in Minecraft
https://Cadiboo.github.io/projects/nocubes/
GNU Lesser General Public License v3.0
140 stars 12 forks source link

Disable smoothing of the tree leaves #90

Closed MiltonBain closed 2 years ago

MiltonBain commented 2 years ago

I cannot figure out how to disable the smoothing of the tree leaves. I can press the hotkey "n" in game to temporarily disable it, but if I leave the game and join back, it is not disabled anymore.

If someone can point me in the direction of how to disable the smoothing of certain blocks, that would be great. Thanks!

Cadiboo commented 2 years ago

The n hotkey is how smoothness is toggled. It should persist between leaving and joining the same world. If it’s not please share a video & your debug.log from .minecraft/logs. If you want custom defaults for every world look into using forges defaultconfigs system.

MiltonBain commented 2 years ago

Here is a dropbox link to a video I recorded (sorry for any compression that occurred.)

Video Link Here

Here's a link to the logs on dropbox. Log One Log Two

It does seem that upon leaving and rejoining, it does stick, but if I quit the game and rejoin, the settings are then reset.

Secondly, I am unsure if this is a product of Minecraft or the rendering engine, but you can see in the video I had to kind of finesse it to smooth them out, and when I pressed the 'n' hotkey, it did not get all the leaves on that tree.

Thirdly, I noticed that in "saves/[world_name]/serverconfig" is where the mod file writes the configuration to, nocubes-server.toml. Is there a way to edit the blacklist manually? I tried putting in "minecraft:oak_leaves" and whatnot but that did not seem to change anything. Looking into that further I noticed each blacklisted item had 2 more fields, [range, persistence]. What exactly do these do?

Cadiboo commented 2 years ago

I don’t have time right now but I’ll take a look at the video and logs in the next couple days.

I tried putting in "minecraft:oak_leaves" and whatnot but that did not seem to change anything. Looking into that further I noticed each blacklisted item had 2 more fields, [range, persistence]. What exactly do these do?

The lists in the config store blockstate identifiers, not block identifiers. So putting “oak_leaves” into the list only affects one of the multiple block states, you’ll need to fill out all of the possible variants you want smoothed. The n key does this automatically for you (it adds all blockstates for the block you’re looking at, unless you’re pressing shift). You can read more about these specific properties at https://minecraft.fandom.com/wiki/Leaves F294F4EF-1E16-4DE6-A569-83A7FB15D8BD

Cadiboo commented 2 years ago

@MiltonBain It looks like you're using a release (fe6e9dea) from before the config issue was fixed. Please upgrade

Screen Shot 2022-08-13 at 12 42 06 pm