search

CadixDev / Bombe

A model of Java types, as per the JVMS specification.
BSD 3-Clause "New" or "Revised" License
6 stars 6 forks source link

Make Bombe work in a modular environment #12

Closed zml2008 closed 4 years ago

zml2008 commented 4 years ago

This PR adds an Automatic-Module-Name metadata field to each artifact, so that bombe can be used in a modular environment.

Because JPMS prohibits split packages (classes in the same package but in multiple jars/modules), the jar package in one of the projects will have to change names. That makes this PR a breaking change. I chose another name for the package in the main project, but that is of course open to changes.

codecov[bot] commented 4 years ago

Codecov Report

Merging #12 into develop will decrease coverage by 0.23%. The diff coverage is 11.11%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #12      +/-   ##
===========================================
- Coverage    26.19%   25.95%   -0.24%     
===========================================
  Files           42       43       +1     
  Lines          672      678       +6     
  Branches        82       83       +1     
===========================================
  Hits           176      176              
- Misses         478      484       +6     
  Partials        18       18
Impacted Files Coverage Δ
...analysis/asm/ClassProviderInheritanceProvider.java 0.00% <ø> (ø)
...ixdev/bombe/provider/ClassLoaderClassProvider.java 0.00% <ø> (ø)
...ava/org/cadixdev/bombe/provider/ClassProvider.java 0.00% <ø> (ø)
.../cadixdev/bombe/provider/JarFileClassProvider.java 0.00% <ø> (ø)
...rg/cadixdev/bombe/type/MethodDescriptorReader.java 70.00% <ø> (ø)
...cadixdev/bombe/type/signature/MethodSignature.java 0.00% <0.00%> (ø)
...ev/bombe/type/signature/MethodSignatureReader.java 0.00% <0.00%> (ø)
...java/org/cadixdev/bombe/type/MethodDescriptor.java 31.81% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2ddfc7a...9b773ce. Read the comment docs.

jamierocks commented 4 years ago

I like the refactor, seems it was an oversight to leave them in jar anyway.

Will get this merged when I'm at a pc - thanks for the pr :)