Closed zml2008 closed 3 years ago
Merging #18 (c822ed1) into develop (7adf3c4) will increase coverage by
2.81%
. The diff coverage is76.59%
.
@@ Coverage Diff @@
## develop #18 +/- ##
===========================================
+ Coverage 25.50% 28.31% +2.81%
===========================================
Files 44 44
Lines 694 731 +37
Branches 88 93 +5
===========================================
+ Hits 177 207 +30
- Misses 498 502 +4
- Partials 19 22 +3
Impacted Files | Coverage Δ | |
---|---|---|
.../java/org/cadixdev/bombe/jar/JarManifestEntry.java | 36.36% <0.00%> (ø) |
|
.../java/org/cadixdev/bombe/jar/JarResourceEntry.java | 50.00% <0.00%> (-16.67%) |
:arrow_down: |
...ombe/jar/JarServiceProviderConfigurationEntry.java | 28.57% <0.00%> (ø) |
|
...ain/java/org/cadixdev/bombe/jar/JarClassEntry.java | 77.77% <75.00%> (+11.11%) |
:arrow_up: |
.../java/org/cadixdev/bombe/jar/AbstractJarEntry.java | 76.92% <88.57%> (+15.01%) |
:arrow_up: |
...ev/bombe/jar/asm/JarEntryRemappingTransformer.java | 73.80% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 7adf3c4...c822ed1. Read the comment docs.
This adds multi-release jar handling to the model and updates the remapping transformer to be aware of that information.
There are a few things I'm unsure of here:
JarEntry
uses the version-stripped name as default, exposing the raw name as the [real name](https://docs.oracle.com/en/java/javase/16/docs/api/java.base/java/util/jar/JarEntry.html#getRealName())JarFile
. Especially in its role as aClassProvider
, it might be helpful for Atlas to be aware of multi-release jars.