search

CadixDev / Bombe

A model of Java types, as per the JVMS specification.
BSD 3-Clause "New" or "Revised" License
6 stars 6 forks source link

Implement jar transformation using NIO #7

Closed jamierocks closed 5 years ago

jamierocks commented 5 years ago

@Minecrell feel free to tweak the Travis configurations for everything, and any Java SE 8 development kit will do.

codecov[bot] commented 5 years ago

Codecov Report

Merging #7 into develop will decrease coverage by 2%. The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop       #7      +/-   ##
===========================================
- Coverage    28.97%   26.96%   -2.01%     
===========================================
  Files           35       37       +2     
  Lines          604      649      +45     
  Branches        69       74       +5     
===========================================
  Hits           175      175              
- Misses         411      456      +45     
  Partials        18       18
Impacted Files Coverage Δ
...adixdev/bombe/asm/jar/FileSystemClassProvider.java 0% <0%> (ø)
...be/src/main/java/org/cadixdev/bombe/jar/Jars2.java 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 45312e1...44f3c59. Read the comment docs.

jamierocks commented 5 years ago

I will decouple the work to exception-ify from this PR, so that we can approach that in the best way.

jamierocks commented 5 years ago

I'm going to go against the old-style of JAR transformation (slightly), and go with a different solution I'm currently working on in Symphony.