CadixDev / Mercury

A source transformation and -remapping framework for Java.
Eclipse Public License 2.0
54 stars 23 forks source link

Doesnt remap paper obfhelpers #13

Closed MiniDigger closed 4 years ago

MiniDigger commented 4 years ago

SRG:

MD: net/minecraft/server/AxisAlignedBB/contains (DDD)Z net/minecraft/world/phys/AABB/containsOH (DDD)Z
MD: net/minecraft/server/AxisAlignedBB/e (DDD)Z net/minecraft/world/phys/AABB/contains (DDD)Z

OG code:

    public final boolean contains(Vec3D vec3d) { return c(vec3d); } // Paper - OBFHELPER
    public boolean c(Vec3D vec3d) {
        return this.e(vec3d.x, vec3d.y, vec3d.z);
    }

remapped (doesnt compile :/):

    public final boolean contains(Vec3 vec3d) { return contains(vec3d); } // Paper - OBFHELPER
    public boolean contains(Vec3 vec3d) {
        return this.contains(vec3d.x, vec3d.y, vec3d.z);
    }
MiniDigger commented 4 years ago

turns out I was just dum with my SRG, note the param DDD when its actually a Vec3D...