Index, login view, logo done, style.css updated

svmarinez commented 2 years ago

Index view done
Login view done
Logo created and attached to public files.

pan-alex commented 2 years ago

Styling looks great. The changes to the login/sign-up forms introduced some bugs that would prevent users from signing up and logging in.

Some form fields were missing the "name" attribute
The sign-up form was submitting to the /login route
The sign-up page was missing a confirm password field which was needed for Auth
Some EJS mark-up for displaying login/sign-up errors was still commented out.
Some code in server.js required to connect to the database was still commented out.

Since this PR is coming from a fork I have created a new branch based off of this PR: VARIANT-Index,-login-view,-logo-done,-style.css-updated that addresses the bugs above.

@svmarinez if that side-branch works for you, you can update your branch with the changes in order to keep all of the relevant changes in this PR.

This branch still conflicts with the main branch as it is a few commits behind. Most notably the "todos > flix" refactor. Not sure if someone would like to take on resolving those conflicts.

AllieGie commented 2 years ago

@pan-alex @svmarinez looking at ticket #22 and I'm not I'm sure I understand where things were left off. I'm trying to do a pull on the latest css and don't see the incoming changes since these PR haven't been resolved/merged. I'm worried that things are getting murky particularly with the css. I know a few of us have been working on the css without having everyone's latest changes.

svmarinez commented 2 years ago

@pan-alex @svmarinez looking at ticket #22 and I'm not I'm sure I understand where things were left off. I'm trying to do a pull on the latest css and don't see the incoming changes since these PR haven't been resolved/merged. I'm worried that things are getting murky particularly with the css. I know a few of us have been working on the css without having everyone's latest changes.

If I understood everyone correctly, the routing for the buttons wasn't going the right way. When I stopped coding everything, I was waiting for a review and haven't touched the code since. When I got home, I tried running the server and am just getting nothing but bad auth but checked the messages and am 80% sure it has something to do with having to sign up again?

CadmiumRed40 / FindAFlick

Index, login view, logo done, style.css updated #22