search

Cadrach / lol_ise

Item Set Editor
GNU General Public License v3.0
13 stars 2 forks source link

Import from Mobafire #11

Closed Toilal closed 7 years ago

Toilal commented 7 years ago

First of all thanks for this awesome tool :)

It's only an idea, but it would be great to be able to import a build from mobafire.

I'm also an AngularJS developer, so if you are open to pull requests, I could try to work on this on my spare time. Tell if you are interested about this idea ...

Cadrach commented 7 years ago

Hey, if you want to go ahead! I did not know Mobafire had an export format for their build.

Keep in mind the following when adding features:

Do not hesitate to reach out if you want more info!

Toilal commented 7 years ago

Mobafire doesn't have any export format.

I was thinking of performing a javascript HTTP Request to parse the HTML page from Mobafire, but I think it will require some CORS configuration on the server.

Cadrach commented 7 years ago

If you need CORS, I can add script on the server in PHP to do that. It would accept only URL to mobafire (so probably extract the ID of the build from the passed URL, rebuild a secure URL and fetch that for the tool). What do you think?

You would pass something like this: http://www.mobafire.com/league-of-legends/build/amumu-wrapping-up-the-jungle-37186 And the script would fetch this: http://www.mobafire.com/league-of-legends/build/37186

Cadrach commented 7 years ago

I have pushed a php script that returns a build from lolking as a JSON set. I will next add the interface in the tool to import the set from the guide (and make room for mobafire too). I feel that if we need CORS, we might as well ask PHP to return a clean object.

How are you proceeding with the feature? I can do it for mobafire too if you want.

Toilal commented 7 years ago

Yes go ahead if you are ready ! Peu de temps, et j'ai passé un peu de temps sur le nouveau squelette du pull request, il me reste un problème a régler encore.

Le 6 janv. 2017 5:28 PM, "Cadrach" notifications@github.com a écrit :

I have pushed a php script that returns a build from lolking as a JSON set. I will next add the interface in the tool to import the set from the guide (and make room for mobafire too)

How are you proceeding with the feature? I can do it for mobafire too if you want.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Cadrach/lol_ise/issues/11#issuecomment-270941792, or mute the thread https://github.com/notifications/unsubscribe-auth/ABHJvpnTePYIdKccq2QVSIulEzXDLHgNks5rPmt5gaJpZM4LYZPD .

Cadrach commented 7 years ago

Du coup je le fais pour mobafire aussi? Ca renverra un json propre direct normalement. Ou plusieurs sets même car je crois que sur mobafire on peut en avoir plusieurs par page.

Toilal commented 7 years ago

Oui oui fait le ☺️ merci ! Ça sera plus simple de le faire en PHP plutôt qu'en full javascript.

Le 6 janv. 2017 5:30 PM, "Cadrach" notifications@github.com a écrit :

Du coup je le fais pour mobafire aussi? Ca renverra un json propre direct normalement. Ou plusieurs sets même car je crois que sur mobafire on peut en avoir plusieurs par page.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Cadrach/lol_ise/issues/11#issuecomment-270942569, or mute the thread https://github.com/notifications/unsubscribe-auth/ABHJvkngb_mwWZ9MmyfO-1H3Uqu23oBdks5rPmxBgaJpZM4LYZPD .

Cadrach commented 7 years ago

Deployed in 0.8

EagleExe commented 4 years ago

2020 version here https://github.com/EagleExe/LoL-ItemsJSON