search

CadyIO / hangfire-ravendb

RavenDB job storage for Hangfire
https://www.nuget.org/packages/Hangfire.Raven/
18 stars 35 forks source link

RavenDB 4 support #29

Open adsamcik opened 6 years ago

adsamcik commented 6 years ago

Still needs some work, but currently it seems to work well. Currently some of the session loads should be replaced with patches which I didn't have time for yet. But current state is better than nothing.

AustinWinstanley commented 6 years ago

Wow. This is amazing work. Thanks @adsamcik! I haven't had a chance to review it and test it yet, but I will soon and I will merge it in if everything looks good,

adsamcik commented 6 years ago

I have been learning RavenDB on it so it might not be as good and optimized as someone else could make it, but I have been using it for awhile and it seems mostly ok. To get it working I removed patches and indexes because I had no idea how they worked. Also in repository I had hard time modifying it so I just created the most basic way and it worked for my case, like I said, almost no experience with this.

AustinWinstanley commented 6 years ago

I'll take a look soon, but indexes are a core part of RavenDB. Without Indexes, it won't be able to be merged. Like I said, I'll check it out though.

adsamcik commented 6 years ago

True, but since 4.0 at least I think it is since 4.0, RavenDB can create them automatically based on queries. So it wasn't a priority for me to add them manually.

JudahGabriel commented 6 years ago

What's the status of this PR? I'd like to use Hangfire.Raven with the latest Raven release (4.1 at the time of this writing).

Echarnus commented 5 years ago

Is this still in development?

adsamcik commented 5 years ago

Is this still in development?

No, but you can always fork it/download it and build it yourself (since it never got merged). I used it for quite some time without major issues, but I don't know if it works well with RavenDB 4.2 since I decided to abandon server side for the project I made this for.

From what I remember there are couple of things that need improving but overall it should work fine. Index creation comes to mind (IIRC it relies on RavenDB to create indexes as needed), but surely there are more things.

//Edit I noticed that you already made PR. I hope my previous work helps you :)