search

Caealana / Flicks

0 stars 0 forks source link

Week 2 Homework #3

Open Caealana opened 8 years ago

Caealana commented 8 years ago

/cc @codepathreview

minhkhang1795 commented 8 years ago

I do not see files of your Week 2 assignment. Please make sure you have pushed all your latest project files to your GitHub Repo. Also, please indicate your time spent on project 2.

Best. Khang CodePath Grader

Caealana commented 8 years ago

Ok. I apologize. It looks like I pushed incorrectly. The code is up now. Thanks!

minhkhang1795 commented 8 years ago

:+1: Nice work! The point of this homework was to get familiar with two common forms of navigation in iOS (push and tab bar). It also provided a chance to extend your Flicks app in new ways.

We have a detailed Project 2 Feedback Guide which covers the best practices for implementing this assignment. Read through the feedback guide point-by-point to determine ways you might be able to improve your submission. You should consider going back and implementing these improvements as well. Keep in mind that one of the most important parts of iOS development is learning the correct patterns and conventions.

For your concerns, you can add an image to your tab bar item programmatically by using 

<name_of_your_navigation_controller>.tabBarItem.image = UIImage(named: "<image_name>")

in which image_name is the name of image in your Image Assets. Also, you can look at this for different tab bar item's sizes. It's a little tricky for that.

Your text gets cut off because your Scroll View's height is not long enough for the content. For this assignment when auto-layout is not concerned, you can fix that bug by increasing the Scroll View's height, which I suggest doing so programmatically because we do not know the exact content's size of each movie's description. Note: our generic feedback above shows a different way to display the movie detail page, so don't get confused about that.

If you have any particular questions about the assignment or the feedback, feel free to reply here or email us at universitysupport@codepath.com.

Best, Khang CodePath Grader