Caeden117 / ChroMapper

GitHub repository for ChroMapper, the Unity-based map editor for Beat Saber.
https://cm.topc.at/dl
GNU General Public License v2.0
300 stars 87 forks source link

ADB permissions on Mac/Linux #458

Closed Fernthedev closed 1 year ago

Fernthedev commented 1 year ago

It's been made apparent that for whatever reason the executable permissions required to invoke adb on Mac or Linux are lost when extracting the zip. See #446's steps

The zip does have the permission attributes as shown here: (windows and mac respectively) image image

This also cleans up a memory leak when downloading and reading the zip.

I haven't tested this on my Linux machine, though I'd greatly appreciate if someone could vouch for it.

I'll leave it as a ready PR regardless though.