NAudio support - Githubissues

Caeden117 / ChroMapper

GitHub repository for ChroMapper, the Unity-based map editor for Beat Saber.

https://cm.topc.at/dl

GNU General Public License v2.0

295 stars 86 forks source link

NAudio support #491

Open Elecast2 opened 9 months ago

Elecast2 commented 9 months ago

Add NAudio with NVorbis support for better song waveform manipulation and improved delays.

TO DO:

Add song speed compatibility (Using a custom WaveProvider?)
Clean code, maybe use a separated file for anything NAudio related
Get volume from Master, currently it updates volume from song volume but doesn't multiply with master

Important changes are in AudioTimeSyncController.cs and SongTimelineController.cs, Everything else is from Plugins

GalaxyMaster2 commented 8 months ago

I'm concerned about how this will impact hitsound/metronome synchronization. It might be necessary to handle those through NAudio as well

Elecast2 commented 8 months ago

I'm concerned about how this will impact hitsound/metronome synchronization. It might be necessary to handle those through NAudio as well

Eventually the best would be to handle all through NAudio, it will require to write a mixer from scratch tho. Still I think it is more important to find a way to make song speed work before doing all of that.