Closed Caeden117 closed 2 months ago
Quick Linux+AMD testing:
Spectrogram not showing up in editor is probably from the last push I did oops. (Tunneled too hard on the masking.) Fixed.
However for the other issue, that mystery scrollbar might be the console opening but failing to render everything else for whatever reason. There's hopefully a useful error in that log.
Spectrogram artifacts do actually appear in the 3D editor when using low sample quality settings:
Okay, previous issues seem fixed, not sure if it was the last commit or me forcing Unity to use Vulkan. But I bring a new bug!
The spectrogram seems to go "choppy" over time. It's immediately noticeable on the song info screen, but the editor one goes eventually as well.
Dev:
GPU Spectrogram (first time):
After viewing other maps:
Editor, near end of song:
Subsequent song loads:
Also yes, lots of graphics errors in the logs. These errors don't show up in the editor, only the build, but the above bug is present in both. ChroMapper.log
This PR completely redesigns ChroMapper's spectrogram, now accelerated by the graphics card. The new spectrogram can generate in fractions of time compared to the old one, and can now be completely hidden by the loading screen.
New spectrogram settings have been added, including:
3D Spectrogram has served no functional purpose for years and is officially removed as of this PR.
This also includes a CrowdIn pull since new localization keys had to be made and I was worried about losing potential localizations that haven't yet been pulled.
Known Issues:
Certain songs produce artifacting on the top and bottom edges of the song preview:These artifacts seem to be resolution dependent, and don't show in the 3D editorThe spectrogram preview also doesn't respect the UI mask, which would hide the aforementioned artifactingFixed mask but artifacting still shows