search

CaedenPH / Jarvide

jarvide is a mix of an AI and an IDE that can securely run, save, edit, read, create, rename files all with a couple clicks of buttons.
MIT License
23 stars 17 forks source link

GIF Commands (like slap and those) #68

Open osam7a opened 2 years ago

osam7a commented 2 years ago

I Have an api key on GIPHY.com and i can get gifs from there, can you maybe put my key in the hidden.py and i will make the commands?

StrangeEcho commented 2 years ago

Negative comrade. To stay consistent with all of our commands we will use the same exact API. Atleast for the Roleplay commands that are featured in the Fun cog. I believe we established on https://waifu.pics as the main choice. Requires no api key and very rare that you will get 429d

osam7a commented 2 years ago

but that isnt even a gif website? am talking about something different than this

osam7a commented 2 years ago

or maybe i can just make 1 "gif" command that gets a gif ffrom the query

StrangeEcho commented 2 years ago

Your purpose in this issue was talking about using giphy for commands like slap and kiss and whatnot. As it is, waifu.pics has a gif endpoint for most of our Roleplay commands. See here for reference https://waifu.pics/docs

osam7a commented 2 years ago

i didnt mean just those, i meant to use giphy to get gifs (from queries or randomly)

StrangeEcho commented 2 years ago

I only assumed so, since that seemed that was the scope of your issue title. Elaborate more on this command you're proposing. Break down how it would work as well.

osam7a commented 2 years ago

so probably you know giphy its a gif website that has ALOOTTT of gifs, i can make commands like maybe jarvide gif random this would get a random gif or jarvide gif <some topic> would give a random gif of this topic or any other commands, i already made an app at there dashboard and i have a key

StrangeEcho commented 2 years ago

Interesting. So you won’t be using giphy for Jarvide's commands. If so, your idea is fine. Just submit a PR. And follow the workflow procedure I touched on in #announcements.

osam7a commented 2 years ago

okay, can you add my api key in hidden.py

Pandabweer commented 2 years ago

Any update on how this is going to get implemented?

osam7a commented 2 years ago

just waiting for caeden to put my key in hidden.py

wasi-master commented 2 years ago

Why not just use a .env file for API tokens, that's the industry standard. Python files should be avoided imo