search

CaedenPH / Jarvide

jarvide is a mix of an AI and an IDE that can securely run, save, edit, read, create, rename files all with a couple clicks of buttons.
MIT License
23 stars 17 forks source link

reformat cooldown error message #77

Closed Kamiikrazy closed 2 years ago

StrangeEcho commented 2 years ago

I see no point of building the embed and binding it to a variable that you use once. Just build the embed inside the send method. Making one use variables takes up unnecessary memory.

Kamiikrazy commented 2 years ago

ok

Robin5605 commented 2 years ago

I say we keep the variable for readability. It uses up such little memory it's negligible. I also suggest you reformat the title variable to be like so:

title = [
    ...,
    ...,
    ...,
]

I approve this change regardless of if you implement these changes or not, they are just for readability.

StrangeEcho commented 2 years ago

That may be so. But neglecting any optimization is substandard. Also in most commands and methods we've already gone with building the embed in the send method. So the change wouldn’t be just for a small amount of optimization but code base consistency as well.

Kamiikrazy commented 2 years ago

thanks for the reviews, will keep in mind to reduce unnecessary memory in the future.