Use ModifyVariable instead of Redirect in BowItemMixin

CafeteriaGuild / DeepMobLearning-Refabricated

Rework of Deep Mob Learning mod for FabricMC

https://www.curseforge.com/minecraft/mc-mods/deep-mob-learning-refabricated

GNU Lesser General Public License v3.0

38 stars 10 forks source link

Use ModifyVariable instead of Redirect in BowItemMixin #132

Closed unilock closed 1 year ago

unilock commented 1 year ago

This is a better fix than #129 since it actually works.

Tested with All of Fabric 6 v1.9.1 on Fabric, as well as an instance of the same modpack modified to use Quilt (with QFAPI 4.0.0-beta.30 / QSL 3.0.0-beta.29 instead of Fabric API).

Fixes #122.

Luligabi1 commented 1 year ago

@unilock can you revert 16d8af3? I'm having a hard time solving the merge conflict and the 1.20 branch (where I'm merging this into) already has an even newer release of Gradle.

unilock commented 1 year ago

@Luligabi1 Done!

Luligabi1 commented 1 year ago

Thank you! It'll be included on the next release of DML for 1.20, releasing still this week 😉

Alkiasan commented 10 months ago

Sorry to necro, but I don't suppose you have an artefact of when this PR was on 1.19.2? Edit: Managed to do this myself, not sure if you need it, but if you want the jar let me know and i'll upload it for others to use! :)