Minor Changes - Githubissues

CaffeineMC / hydrogen-fabric

Things of which are too dangerous to put in Lithium.

GNU Lesser General Public License v3.0

510 stars 66 forks source link

Minor Changes #35

Closed DragonEggBedrockBreaking closed 3 years ago

DragonEggBedrockBreaking commented 3 years ago

I have made some small changes to some parts of the GitHub repository:

Removed 'forge' from contributing.md
Semi-rewrote readme, for parity with sodium's recent change (see the branch for this PR on my fork for a visual representation of the new README)
Some changes in fabric.mod.json

Unlike what many may expect, I did not set the homepage to modrinth/curseforge, and you can find my reasoning in JellySquid's comment on this sodium PR.

I set the project homepage to https://jellysquid.me/projects/ so that it would be more related to the mods.

DragonEggBedrockBreaking commented 3 years ago

Changed ci names, because they were changed in sodium

DragonEggBedrockBreaking commented 3 years ago

Changed links from jellysquid3 to CaffeineMC

DragonEggBedrockBreaking commented 3 years ago

I bumped the loom version to 0.6 and changed modCompile to modImplementation so that this builds on JDK 16 + Gradle 7.0-rc1 (minimum gradle version for JDK 16). I believe both of these changes are backwards compatible. This is likely the last change I will do.

DragonEggBedrockBreaking commented 3 years ago

I have removed the homepage link in fabric.mod.json due to its recent removal in the sodium repo.

DragonEggBedrockBreaking commented 3 years ago

You may have seen that I created a new PR for updating to Gradle 7 on the Lithium and Phosphor repositories, but I will not do that here for the time being, since the main reason is to build on JDK 16, and imo it is best for the mod to run on 16 first.

DragonEggBedrockBreaking commented 3 years ago

I feel like this PR is not as necessary as the Sodium, Phosphor and Lithium PRs. I will likely not maintain this.