fix: removes redundant ticket add when not needed

CaffeineMC / lithium-fabric

A Fabric mod designed to improve the general performance of Minecraft without breaking things

GNU Lesser General Public License v3.0

1.94k stars 190 forks source link

fix: removes redundant ticket add when not needed #449

Closed ishland closed 1 year ago

ishland commented 1 year ago

There is a missing check for create parameter in ServerChunkManagerMixin#getChunkBlocking and it does not match vanilla behavior as the ticket should be added only when explicitly requested. This PR fixes this issue.

Additionally, guarding ticket add here also slightly decreases MSPT (452 to 443 with 101 players spread in radius 2048) before: https://spark.lucko.me/z8TuFzcT29 after: https://spark.lucko.me/3l2JcNRxAE