search

CaffeineMC / lithium-fabric

A Fabric mod designed to improve the general performance of Minecraft without breaking things
GNU Lesser General Public License v3.0
1.94k stars 189 forks source link

change: use main worker executor for util.block_tracking #474

Closed embeddedt closed 1 year ago

embeddedt commented 1 year ago

Proposed Changes

Changes the CompletableFuture used in mixin.util.block_tracking to run on the normal Mojang background executor instead of the common ForkJoinPool. Use of the latter can cause issues with mods as it does not have the correct context classloader set (due to being initialized before the modloader). An example of such an issue is https://github.com/Fuzss/puzzleslib/issues/41; there were many mods involved but the problem originated with Lithium running code on the common ForkJoinPool in the first place.

2No2Name commented 1 year ago

Thank you for this PR. Merged manually