search

CaffeineMC / lithium-fabric

A Fabric mod designed to improve the general performance of Minecraft without breaking things
GNU Lesser General Public License v3.0
1.94k stars 189 forks source link

Fix crash with betterchunkloading mod #568

Open lugui1998 opened 1 month ago

lugui1998 commented 1 month ago

There is a issue involving Betterchunkloading mod that causes the server to crash when a player moves enough to unload chunks. this.positionWithExpiringTicket.get(pos) are presumed to never be null but rather a list that could be empty. More debugging is needed in order to find the reason why this would ever return a null value, which is probably Betterchunkloading's fault, regardless, this check will prevent the server from crashing on a situation like this.

2No2Name commented 1 month ago

I interpret the given NullPointerException issue at a hint at incompatible changes in the two mods. Adding a simple null check may completely resolve the issue, but it is also very likely that there are other incompatibilities which are hidden by the additional null check. I think investigating why the NullPointerException happens in the first place is needed.