CaffeineMC / lithium-fabric

A Fabric mod designed to improve the general performance of Minecraft without breaking things
GNU Lesser General Public License v3.0
1.94k stars 189 forks source link

lithium makes productive bees bees and nests unable to spawn #589

Open VaporeonScripts opened 4 days ago

VaporeonScripts commented 4 days ago

latest version of lithium neoforge 1.21.1 .80 arch linux OS https://mclo.gs/A9bKS1h

2No2Name commented 4 days ago

The issue seems to be that they are returning the wrong block entity type when calling BlockEntity::getType() during block entity initialization. Lithium uses the method very early to check whether the block at the position supports the block entity.

2No2Name commented 4 days ago

Marking as external as I think the other mod is violating a very reasonable assumption, i.e. that the block entity type of a block entity is correct from the start.

VaporeonScripts commented 3 days ago

Aight,ima let U guys find a solution between productive bees and lithium,as I saw on productive bees part

2No2Name commented 3 days ago

The solution is to disable the optimization

VaporeonScripts commented 3 days ago

which one specifically?

VaporeonScripts commented 3 days ago

?

2No2Name commented 3 days ago

Workaround is to add the line mixin.minimal_nonvanilla.world.block_entity_ticking.support_cache=false to the lithium.properties file in the config folder and restarting the game. There should not be lasting damage to your world, since the beehives just weren't ticked when the issue occurred.

VaporeonScripts commented 3 days ago

I disabled another one and it worked? Lemme show

VaporeonScripts commented 3 days ago

mixin.world.block_entity_ticking=false

2No2Name commented 3 days ago

Yes, the support_cache optimization depends on the general block entity ticking optimization. But disabling that also disables a few other optimizations that might not have a problem

VaporeonScripts commented 3 days ago

So would be better to disable cache one? So that it fixes the issue while improving perf?

2No2Name commented 3 days ago

Yes

VaporeonScripts commented 3 days ago

aight,ty

2No2Name commented 3 days ago

It seems like the issue may be fixed in the future by productive bees mod authors, will check again in a while.