search

CaffeineMC / phosphor-fabric

A Fabric mod designed to dramatically improve the performance of Minecraft's lighting engine while fixing many bugs
GNU Lesser General Public License v3.0
1.11k stars 71 forks source link

Lava light update issues [1.18.1] #73

Closed TheSnowyChickens closed 2 years ago

TheSnowyChickens commented 2 years ago

Hello,

in the nether, some flowing lava create chunk based light issues. (second time this happend, relogging can fix it) (it is a Vanilla - Paper Server with some datapacks)

grafik

Fabric-loader-0.12.11-1.18.1 Phosphor-fabric-mc1.18.x-0.8.1 grafik

Reproduce: find a lava spot, let the lava flow in many directions and remove the source.

With "Starlight" and no light engine mod, I can't create light issues.

PhiProven commented 2 years ago

I'm unable to redproduce the issue. This sounds like MC-172980, which would be a Vanilla bug. Can you please test again with and without Phosphor on the exact same setup, i.e., same seed and coordinates. In case it only happens with Phosphor, can you please also try with all other mods except Phosphor removed?

TheSnowyChickens commented 2 years ago

Oh grafik (/\ Vanilla only)

Then I am sorry. :D I instantly played with fabric and never with pure vanilla on the server, so I could not experience this bug.

Is there maybe a chance that you can fix this vanilla bug with phosphor ?

(I close the issue)

PhiProven commented 2 years ago

Not really. A proper fix requires to validate the borders of all received lightmaps. Vanilla implemented this at some point, but it was removed again due to tremendous lag.