CaffeineMC / sodium-fabric

A Minecraft mod designed to improve frame rates and reduce micro-stutter
Other
4.76k stars 810 forks source link

Xaero's world map broken #1093

Closed Cloudperry closed 2 years ago

Cloudperry commented 2 years ago

Version information

mc1.18.1-0.4.0-alpha5+build.851

Expected Behavior

Xaero's world map should render normally.

Actual Behavior

Xaero's world map renders completely black.

Reproduction Steps

  1. Load into a world where Xaero's world map previously worked
  2. Look at Xaero's world map and it renders completely black

Java version

Java 17.0.1 64-bit

CPU

Ryzen 3600

GPU

Rx Vega 56

Additional information

Mod list (from Fabric logs, because I use a mod manager that changes jar names to its own ids)

``` [15:14:53] [main/INFO]: Loading 143 mods: - advanced_runtime_resource_pack 0.5.4 - advancementinfo 1.18-fabric0.43.1-1.3 - animatica 0.2+1.18 - antighost 1.18-fabric0.43.1-1.1.4 - architectury 3.4.9 - autoconfig1u 3.3.1 via image2map - bettermounthud 1.1.3 - bettersafebed 1.18-fabric-a - blue_endless_jankson 1.2.1 via kyrptconfig - brb 1.5.6 - capes 1.2.2+1.18 - carpet 1.4.56 - carpet-autocraftingtable 1.4.56 - carpet-extra 1.4.56 - cem 0.7.0 - citresewn 0.8.2+1.18.1 - cloth-api 2.0.54 - cloth-basic-math 0.6.0 via cloth-config - cloth-client-events-v0 2.0.54 via cloth-api - cloth-common-events-v1 2.0.54 via cloth-api - cloth-config 6.1.48 - cloth-datagen-api-v1 2.0.54 via cloth-api - cloth-scissors-api-v1 2.0.54 via cloth-api - cloth-utils-v1 2.0.54 via cloth-api - com_github_meteordevelopment_starscript 0.1.5 via respackopts - com_moandjiezana_toml_toml4j 0.7.2 via dynamicfps - com_velocitypowered_velocity-native 1.1.0-SNAPSHOT via krypton - commandaliases 0.5.0 - connected-doors 1.1+1.18 - continuity 1.0.3+1.18 - crowdin-translate 1.4+1.18 via antighost - cullleaves 2.3.2 - dcch 2.0+1.17 - dynamicfps 2.0.6 - enchdesc 9.0.7 - enhancedblockentities 0.5+1.18 - entityculling 1.3.3 - fabric 0.45.0+1.18 - fabric-api-base 0.4.1+b4f4f6cd65 via fabric - fabric-api-lookup-api-v1 1.5.0+17be577f65 via fabric - fabric-biome-api-v1 6.0.1+ded849a965 via fabric - fabric-blockrenderlayer-v1 1.1.9+3ac43d9565 via fabric - fabric-command-api-v1 1.1.6+3ac43d9565 via fabric - fabric-commands-v0 0.2.5+b4f4f6cd65 via fabric - fabric-containers-v0 0.1.18+d154e2c665 via fabric - fabric-content-registries-v0 0.4.5+6f53a73d65 via fabric - fabric-crash-report-info-v1 0.1.8+3ac43d9565 via fabric - fabric-dimensions-v1 2.1.7+43d2957165 via fabric - fabric-entity-events-v1 1.4.5+6b21378a65 via fabric - fabric-events-interaction-v0 0.4.16+bfa23f1765 via fabric - fabric-events-lifecycle-v0 0.2.6+b4f4f6cd65 via fabric - fabric-game-rule-api-v1 1.0.10+3ac43d9565 via fabric - fabric-item-api-v1 1.3.0+691a79b565 via fabric - fabric-item-groups-v0 0.3.3+3ac43d9565 via fabric - fabric-key-binding-api-v1 1.0.8+c8aba2f365 via fabric - fabric-keybindings-v0 0.2.6+b4f4f6cd65 via fabric - fabric-language-kotlin 1.7.1+kotlin.1.6.10 - fabric-lifecycle-events-v1 1.4.10+c15ca33565 via fabric - fabric-loot-tables-v1 1.0.8+3ac43d9565 via fabric - fabric-mining-level-api-v1 1.0.3+3ac43d9565 via fabric - fabric-mining-levels-v0 0.1.7+b4f4f6cd65 via fabric - fabric-models-v0 0.3.3+3ac43d9565 via fabric - fabric-networking-api-v1 1.0.18+3ac43d9565 via fabric - fabric-networking-v0 0.3.5+b4f4f6cd65 via fabric - fabric-object-builder-api-v1 1.11.0+3b82842e65 via fabric - fabric-object-builders-v0 0.7.8+3ac43d9565 via fabric - fabric-particles-v1 0.2.9+526dc1ac65 via fabric - fabric-registry-sync-v0 0.8.6+533be9ba65 via fabric - fabric-renderer-api-v1 0.4.9+3ac43d9565 via fabric - fabric-renderer-indigo 0.4.12+3ac43d9565 via fabric - fabric-renderer-registries-v1 3.2.7+b4f4f6cd65 via fabric - fabric-rendering-data-attachment-v1 0.3.4+7242e9d765 via fabric - fabric-rendering-fluids-v1 0.1.18+3ac43d9565 via fabric - fabric-rendering-v0 1.1.9+b4f4f6cd65 via fabric - fabric-rendering-v1 1.10.3+6b21378a65 via fabric - fabric-resource-loader-v0 0.4.11+3ac43d9565 via fabric - fabric-screen-api-v1 1.0.7+3ac43d9565 via fabric - fabric-screen-handler-api-v1 1.1.11+3ac43d9565 via fabric - fabric-structure-api-v1 2.0.8+295197a765 via fabric - fabric-tag-extensions-v0 1.2.5+3ac43d9565 via fabric - fabric-textures-v0 1.0.9+3ac43d9565 via fabric - fabric-tool-attribute-api-v1 1.3.4+7de09f5565 via fabric - fabric-transfer-api-v1 1.5.6+b4f4f6cd65 via fabric - fabricloader 0.12.12 - fabrishot 1.6.0 - ferritecore 4.0.0 - image2map 0.2.2 - indium 1.0.2-alpha1+mc1.18 - inspecio 1.1.0+1.17 - inventorysorter 1.8.1-1.18 - iris 1.1.4-starline+build.672 - itemmodelfix 1.0.3+1.18 - java 17 - krypton 0.1.6 - kyrptconfig 1.2.5-1.18 via inventorysorter - lambdabettergrass 1.2.2+1.17 - lambdynlights 2.1.0+1.17 - lazydfu 0.1.2 - libjf-base 2.2.0 via respackopts - libjf-data-manipulation-v0 2.2.0 via respackopts - libjf-unsafe-v0 2.2.0 via respackopts - litematica 0.9.0 - lithium 0.7.6 - malilib 0.10.0-dev.26 - midnightlib 0.2.9 via cullleaves - minecraft 1.18.1 - minihud 0.19.0-dev.20211204.230657 - mm 2.1 via slight-gui-modifications - modmenu 3.0.1 - morechathistory 1.1.0 - no-telemetry 1.3.0 - notenoughanimations 1.4.0 - org_anarres_jcpp 1.4.14 via iris - org_codehaus_groovy_groovy 3.0.8 via slight-gui-modifications - org_codehaus_groovy_groovy-jsr223 3.0.8 via slight-gui-modifications - org_jetbrains_kotlin_kotlin-reflect 1.6.10 via fabric-language-kotlin - org_jetbrains_kotlin_kotlin-stdlib 1.6.10 via fabric-language-kotlin - org_jetbrains_kotlin_kotlin-stdlib-jdk7 1.6.10 via fabric-language-kotlin - org_jetbrains_kotlin_kotlin-stdlib-jdk8 1.6.10 via fabric-language-kotlin - org_jetbrains_kotlinx_kotlinx-coroutines-core-jvm 1.5.2 via fabric-language-kotlin - org_jetbrains_kotlinx_kotlinx-coroutines-jdk8 1.5.2 via fabric-language-kotlin - org_jetbrains_kotlinx_kotlinx-serialization-cbor-jvm 1.3.1 via fabric-language-kotlin - org_jetbrains_kotlinx_kotlinx-serialization-core-jvm 1.3.1 via fabric-language-kotlin - org_jetbrains_kotlinx_kotlinx-serialization-json-jvm 1.3.1 via fabric-language-kotlin - org_joml_joml 1.10.2 via sodium - org_slf4j_slf4j-api 1.7.12 via iris - pinglist 1.3.3 - pride 1.1.0+1.17 via lambdynlights - rebind_all_the_keys 1.1.1+1.18 - reeses-sodium-options 1.2.4 - respackopts 2.9.0 - slight-gui-modifications 2.0.2 - sodium 0.4.0-alpha5+build.816 - sound_physics_remastered 1.18.1-1.0.3 - spruceui 3.3.2+1.17 via lambdabettergrass - starlight 1.0.0+fabric.d0a3220 - syncmatica 0.2.6 - tooltipfix 1.0.4-1.18 - tweakeroo 0.11.0 - wi_zoom 1.3-MC1.18.1 - xaerominimap 21.23.0 - xaeroworldmap 1.19.0 - yosbr 0.1.1 ```

Somehow Xaero's minimap renders just fine. This bug could have something to do with block colors. I had to remove Colormatic that was incompatible with build 851, because it crashed with errors about some block color mixins.

Edit: Actually Xaero's minimap renders black as well, when in unexplored chunks.

Cloudperry commented 2 years ago

I'm just in the process of bisecting this bug and its actually not only on the next branch but on the main 1.18 branch as well. I will update this comment with the exact commit hash that caused this bug in about 10 min.

Edit: Commit 1d498215ffa38bb473ff479d47c7b0a4247aa223 is the first one with this bug and commit a869408e7acd67f3094b9998afce85591c44641c doesn't have it yet.

Edit 2: Adding some screenshots.

Commit a869408e7acd67f3094b9998afce85591c44641c and before it: Screenshot_2022'0109_022200

After commit 1d498215ffa38bb473ff479d47c7b0a4247aa223: Screenshot_20220109_024527

Cloudperry commented 2 years ago

This bug got fixed in one of the newer commits on the next brach.