CaffeineMC / sodium-fabric

A Minecraft mod designed to improve frame rates and reduce micro-stutter
Other
4.74k stars 809 forks source link

It no longer appears to be possible to disable biome blending #2481

Open muzikbike opened 4 months ago

muzikbike commented 4 months ago

Bug Description

In previous versions, the biome blending slider could be set to 0 to show a hard border between blocks within one biome and blocks within another. This no longer seems to be possible - the lowest setting is 1. I do not know if this is an intentional change since I can't see any resolved reports indicating this would have been removed.

This is a different issue from #1450 (it concerns the Smooth Lighting-like biome blending not being toggleable), but images in that ticket show the expected sharp border which would be achievable from a setting of 0.

Reproduction Steps

  1. Set your biome blending to the lowest possible value
  2. Go to the edge of a biome with a significant colour difference

2024-05-06_14 11 24 2024-05-06_14 11 27

Log File

latest.log

Crash Report

crash-2024-05-06_14.13.53-client.txt

MeeniMc commented 4 months ago

Even when set to 0 it would not produce sharp borders because Sodium, in addition to the biome blending, has color smoothing inside the blocks. You can refer to my pr #2267, it re-enables setting bleding to 0, and explains what I just said above. Because it doesn't produce sharp boundaries in any case, the difference between 1 and 0 is very subtle.

muzikbike commented 4 months ago

I remember previous versions didn't produce blended boundaries at 0 though.

ShaneBeee commented 2 months ago

I can here to make a suggestion about this, and saw it was already here. Can confirm, same for me.

I remember a few versions back you could set it to 0 and they were sharp. I personally use this for testing/debugging custom biome stuff. Id love to have this option again.