search

CaffeineMC / sodium-fabric

A Fabric mod designed to improve frame rates and reduce micro-stutter
Other
4.58k stars 773 forks source link

Fluid backfaces use wrong shape on slopes #2570

Closed fayer3 closed 1 week ago

fayer3 commented 1 week ago

Bug Description

Fluid back and front faces on slopes use a differnt triangle layout, which make them not allign and causes visual artefacts

grafik

https://github.com/CaffeineMC/sodium-fabric/assets/8282299/1b2e5c1d-b48c-4323-a6fd-2409977b609e

Reproduction Steps

easiest way to reproduce it, is to build a 2 block tall pyramid, and pour lava over it, the indented slopes will show the issue well when looking from slightly below. grafik grafik

Log File

latest.log

Crash Report

crash-2024-06-23_13.19.04-client.txt

fayer3 commented 1 week ago

using latest 1.21 sodium sodium-fabric-0.5.9+mc1.21.jar

douira commented 1 week ago

Thanks for letting us know the fix for this wasn't in 0.5. I implemented a fix for the duplicate of this issue https://github.com/CaffeineMC/sodium-fabric/issues/609 in dev a while back which has now been backported. This issue can be closed. (and maybe put in the 0.5.11 milestone)