search

CaffeineMC / sodium-fabric

A Minecraft mod designed to improve frame rates and reduce micro-stutter
Other
4.72k stars 807 forks source link

Broken particle animated textures #2740

Open MehVahdJukaar opened 1 week ago

MehVahdJukaar commented 1 week ago

Bug Description

Due to some reports that was sent to me, I noticed that people animated particle textures were not animating when sodium was on. Animation is a normal texture atlas .mcmeta driven texture loop animation.

Now these particles were added via Polytone but the mod itself just registers them to the vanilla registries and sets them up just like ones registered on mod boot, most importantly it doesnt touch stuff related to how the actual particle texture atlas is handled.

I did not look into this further.

Reproduction Steps

Add a particle with Polytone and give it an animated texture. Texture will not be animated on the particle atlas.

Log File

2024-09-09-1.log

Crash Report

2024-09-09-1.log

douira commented 1 week ago

Potentially related to https://github.com/CaffeineMC/sodium-fabric/issues/2722?

jellysquid3 commented 1 week ago

We're still in the process of determining the root cause of the problem. Some progress was made the other day, in which we identified some mods had broken resource reload listeners, that were causing problems with sprite finding in Sodium.

jellysquid3 commented 1 week ago

This change might resolve the issue. Can you see if the nightly build works?

MehVahdJukaar commented 1 week ago

i'll try

MehVahdJukaar commented 2 days ago

Issue seems to persist with that too