search

CaffeineMC / sodium-fabric

A Minecraft mod designed to improve frame rates and reduce micro-stutter
Other
4.72k stars 807 forks source link

Fix light pixels on block edges visible in dark areas - MC-175333 #578

Closed LucilleTea closed 3 years ago

LucilleTea commented 3 years ago

MC-175333

Sky-coloured pixels are sometimes visible on the edges of blocks, particularly noticeable in dark areas. This appears to be a vanilla issue that used to be hidden by Sodium's Compact Vertex Format (on my hardware?). CVF no longer hides the issue after 547c41cf0694fa1b3af5b047eb5f42b1916d3c33, and still not after 2fb1d28aa61680170e44a138c296f3b5534314e0.

This can be reproduced in Sodium by loading this test world with FOV set to the minimum and a game resolution of 2476x1417, for me. With a different FOV or resolution you will have to set your mouse sensitivity low and move slowly until you find it.

The bug seen in Sodium The bug seen in Vanilla

mrmangohands commented 3 years ago

Should be fixed by 0e73f35b2780a40f2c32303a5e815446df06d6d4

Urshee commented 2 years ago

I'm experiencing what seems to be the same issue. Sky-colored pixels/rows of pixels appear on the edges of blocks and are most visible in dark areas, but are sometimes difficult to spot. When I was using Complementary Shaders with Iris Starline installed, which allowed me to enable anti-aliasing (both FXAA and TAA), the issue was much less noticeable. The issue is not present at all for me in vanilla. Below are the screenshots, which also show information on my system and Java/Sodium version via the F3 menu.

Vanilla

2021-12-03_01 25 01

Sodium (no AA)

Just Sodium

FXAA

FXAA

TAA

2021-12-03_01 20 29

callmejay758 commented 2 years ago

Also experiencing the above, also with complementary on. On AOF4, mining is pretty distracting.

Edit, noticed it happens without complementary on, its less noticeable.

Dashiba commented 7 months ago

Having this issue as well, as long as Sodium and Iris are enabled, this happens to me, with or without shaders.

The thing I noticed is this is way... WAY more noticable depending on what mods I have enabled, I don't know why but "Twilight Forest" makes it happen everywhere, all the time.

astridellensdottir commented 7 months ago

you are commenting this on an issue which was closed three years ago. it would be more useful to fill in a new issue with new logs, a crash report, and screenshots from your own issue, as it’s likely similar visually, but caused by something different from what was marked fixed three years ago and having no other reporters.

Dashiba commented 7 months ago

you are commenting this on an issue which was closed three years ago. it would be more useful to fill in a new issue with new logs, a crash report, and screenshots from your own issue, as it’s likely similar visually, but caused by something different from what was marked fixed three years ago and having no other reporters.

Yea I would gladly do that If i had any freaking idea on how GitHub works, I got here by searching it in google.