search

CaffeineMC / sodium-fabric

A Minecraft mod designed to improve frame rates and reduce micro-stutter
Other
4.73k stars 807 forks source link

Glowing optimization #74

Closed Zailer43 closed 1 year ago

Zailer43 commented 4 years ago

Is your feature request related to a problem? Please describes. When I play hypixel skyblock dungeons players have glowing effects and that slightly lowers the fps

Describe the solution you'd like Optimizing the glowing effect

Describe alternatives you've considered Buy me a pc and play at over 60 fps

Additional context 2020-07-09_18 52 39 2020-07-09_18 52 53

HitItAll commented 4 years ago

I like your alternative option

surfaceflinger commented 2 years ago

Not sure on what configurations it happens exactly but it's terrible on Windows 10/11 and Intel HD 4600. And it's fine on Linux/Windows and Intel HD 4000. Looking at #801 it's bad on macOS and Radeon Pro 560 too. Not only it drops FPS but it also creates weird cursor/camera rotation lag that looks like "throttling" and I have also noticed that OptiFine's Smooth FPS fixes rotation lag but drops fps in half when seeing something with the glow effect.

Maybe for now it would be a good idea to just implement a simple toggle that completely disables this effect?

Zailer43 commented 1 year ago

I obtained 37% higher fps with 445 entities with glowing with https://github.com/CaffeineMC/sodium-fabric/commit/2967d1ae865832b044488b16a85846b4d9636431

Felix14-v2 commented 1 year ago

Maybe for now it would be a good idea to just implement a simple toggle that completely disables this effect?

Not sure, since this breaks the whole essence of the glow effect. But you can try other mods like No Glowing