search

CaffeineMC / sodium-fabric

A Minecraft mod designed to improve frame rates and reduce micro-stutter
Other
4.75k stars 808 forks source link

Block outline renders above entities with fabulous graphics. #82

Closed ghost closed 4 years ago

ghost commented 4 years ago

Expected Behavior

Block outline doesn't render above entities when fabulous graphics are on.

Actual Behavior

Block outline renders above entities when fabulous graphics are on.

Reproduction Steps

1-Run this command /summon minecraft:creeper ~ ~ ~ {NoAI:1b} 2-Point at the block under the creeper 3-Notice that the block outline renders above the creeper

Attachments

Excuse the font(it's actually just a bunch of lines forming the text) Gotta_love_the_custom_font New Project

System Information

amnotbananaama commented 4 years ago

Cannot reproduce on latest commit.

I have all Sodium settings on the "Fast" or "Off", except for "Graphics Quality" on "Fabulous". I tried turning a bunch of options on and off, but I still couldn't reproduce the issue. Can you share your Sodium configuration?

ghost commented 4 years ago

I downloaded sodium from curseforge because I was too lazy to build from the latest commit. Here is my "Options.txt" file options.txt and my "sodium-options.json" content because I can't upload it for some reason:

{
  "quality": {
    "cloud_quality": "FAST",
    "weather_quality": "FAST",
    "enable_vignette": false,
    "enable_clouds": false,
    "smooth_lighting": "OFF"
  },
  "advanced": {
    "chunk_renderer_backend": "GL43",
    "animate_only_visible_textures": true,
    "use_advanced_entity_culling": true,
    "use_particle_culling": true,
    "use_fog_occlusion": true,
    "use_compact_vertex_format": true,
    "use_chunk_face_culling": true,
    "use_memory_intrinsics": true,
    "disable_driver_blacklist": false
  }
}
amnotbananaama commented 4 years ago

I still cannot reproduce this with the options you gave above, either with the 0.1 release on CurseForge, or the latest commit. https://i.imgur.com/uccppTl.png

That is not me saying it DOESN'T happen. Clearly something is different between our configurations that is causing you to see something that I'm not.

Are you using any other mods with Sodium?

ghost commented 4 years ago

Yes I am, will test without them later

ghost commented 4 years ago

here is my mod list: fabric api (may it is causing the issue since sodium doesn't support the rendering api) carpet mod fast furnace and fast bench lambdynamiclights lithium logical zoom malilib modmenu not enough crashes phosphor sodium tweakeroo

ghost commented 4 years ago

This mechanics is present with no other mods installed

ghost commented 4 years ago

That's a problem with minecraft only on mesa drivers, nothing to do with sodium.

On vanilla minecraft video settings the game will warn you about mesa graphics not being supported when trying to use fabulous graphics.

ghost commented 4 years ago

Oh I see, Sorry for not saying I'm using mesa drivers, Haven't tested with windows drivers just because I'm lazy.

ghost commented 4 years ago

I think I shall close the issue since it is a vanilla one