Fix water trying to connect to waterlogged blocks it cannot

[muzikbike]

Version information

sodium-fabric-mc1.18.2-0.4.1+build.15

Expected Behavior

Since there is a physical barrier between the flowing water and still water, they should not appear connected.

Actual Behavior

They appear connected anyway. In addition, the still water appears to flow into the flowing water. ![Uploading 2022-03-05_01.00.13.png…]()

Reproduction Steps

1. Create the setup shown in the screenshots above, with water in all stair blocks and a single source at the end
2. Observe the shape of the flowing water

Java version

17.0.2 64bit

CPU

4× Intel® Core™ i3-3240 CPU @ 3.40GHz

GPU

Intel® HD Graphics 2500

Additional information

Vanilla bug https://bugs.mojang.com/browse/MC-127030. Split from #91 due to some changes made in 1.18.2 that fixed similar bugs mentioned in that report.

The water being taller than expected is clearly a rendering artifact, as using Spectator mode reveals that the fog and FOV changes only apply where the expected water height is.

[MeeniMc]

This bug report is incorrect for the following reasons.

1. in some cases, these (weird/incorrect looking) connected water sources are not just graphical glitches, but also have effects in game (e.g., they can accelerate minecarts, see https://youtu.be/1SYSN0jT0Ac?t=252)
2. in this particular case, throwing an item in the flowing water will demonstrate that the item gets push-aligned towards the center line.
3. thus the flowing water is not a visual glitch, but an important information about a real behavior (that may be used for redstone/item transportation): the water is really flowing inside these stairs.

For these reason a fix to this issue should not be implemented.

[muzikbike]

Should this ticket only concern the visual height of the water being incorrect then?