CaffeineMC / sodium

A Minecraft mod designed to improve frame rates and reduce micro-stutter
Other
4.8k stars 812 forks source link

Armor texture packs render incorrectly #2302

Closed CrafterDaemon closed 9 months ago

CrafterDaemon commented 9 months ago

Bug Description

While using Sodium and the Energy Manipulation datapack, I found that the armor renders very poorly for anyone who is using sodium. The bug is purely client-side, as if it (the datapack) is on a server, all players not using sodium render the armor correctly. prplr hblehc

Reproduction Steps

Download and Install Sodium Download and Install a resource pack that modifies armor (attached is the datapack where I encountered the error) energy-manipulation 0.26.0 - minecraft 1.20.2 to 1.20.4.zip xylo-s-resource-pack 0.16.0.zip acquire the retextured armor (Caster armor in the datapack) Equip and use F5, or put the armor on an armor stand.

Log File

latest.log

Crash Report

crash-2024-01-31_22.32.22-client.txt

CrafterDaemon commented 9 months ago

Seems to be an Iris issue, but pops up sodium incompatibility in top corner

CrafterDaemon commented 9 months ago

reopening just in case

CrafterDaemon commented 9 months ago

Tested with another texture pack that changes chestplates to have gloves, no issues. image

CrafterDaemon commented 9 months ago

only happens with shaders enabled Shader effects do not matter afaik

MeeniMc commented 9 months ago

you have a lot of moving parts here, you need to simplify the problem. ETF, 3D-skin layer, Iris, etc may be the root cause.

Try again with only Sodium, and only the resource pack of interest. If that works, do dichotomic search to find which mod breaks it.

coderbot16 commented 9 months ago

Not a Sodium bug, it's triggered by Iris but it's not fixable. https://github.com/IrisShaders/Iris/issues/1042

See the official Iris documentation: https://github.com/IrisShaders/Iris/blob/1.18.2/docs/development/compatibility/core-shaders.md

Core shaders are not supported by Mojang and servers modify them at their own risk. Iris and Sodium each break different parts of them because they simply can't coexist well with advanced rendering mods.