CaffeineMC / sodium

A Minecraft mod designed to improve frame rates and reduce micro-stutter
Other
4.81k stars 810 forks source link

Vanilla shader breaks stained glass #2398

Closed boxic closed 7 months ago

boxic commented 7 months ago

Bug Description

I have a vanilla shader that makes magenta stained glass have a shine on the surface at shallow angles, as well as cycle through a noise pattern in the atlas based on the GameTime variable. However, with sodium, it just renders as completely transparent! Sodium does have a pop-up saying the pack might be incompatible, but I can't deduce why that might be, based solely on latest logs... Below are images of how it should look on Vanilla 1.20.2, then how it looks on Sodium 1.20.2: image image

Reproduction Steps

Load a world or server Place magenta stained glass

Log File

[14:49:19] [main/INFO]: Loading Minecraft 1.20.2 with Fabric Loader 0.15.6 [14:49:19] [main/INFO]: Loading 10 mods:

Crash Report

---- Minecraft Crash Report ---- // Hey, that tickles! Hehehe!

Time: 2024-04-02 14:50:55 Description: Manually triggered debug crash

java.lang.Throwable: Manually triggered debug crash at net.minecraft.class_309.method_1474(class_309.java:514) at net.minecraft.class_310.method_1574(class_310.java:2004) at net.minecraft.class_310.method_1523(class_310.java:1237) at net.minecraft.class_310.method_1514(class_310.java:856) at net.minecraft.client.main.Main.main(Main.java:253) at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:470) at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74) at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)

A detailed walkthrough of the error, its code path and all known details is as follows:

-- Head -- Thread: Render thread Stacktrace: at net.minecraft.class_309.method_1474(class_309.java:514)

-- Manual crash details -- Details: Modules: ADVAPI32.dll:Advanced Windows 32 Base API:10.0.22621.1 (WinBuild.160101.0800):Microsoft Corporation AUDIOSES.DLL:Audio Session:10.0.22621.1 (WinBuild.160101.0800):Microsoft Corporation COMCTL32.dll:User Experience Controls Library:6.10 (WinBuild.160101.0800):Microsoft Corporation CRYPT32.dll:Crypto API32:10.0.22621.1 (WinBuild.160101.0800):Microsoft Corporation CRYPTBASE.dll:Base cryptographic API DLL:10.0.22621.1 (WinBuild.160101.0800):Microsoft Corporation CRYPTSP.dll:Cryptographic Service Provider API:10.0.22621.2506 (WinBuild.160101.0800):Microsoft Corporation CoreMessaging.dll:Microsoft CoreMessaging Dll:10.0.22621.3085 (WinBuild.160101.0800):Microsoft Corporation CoreUIComponents.dll:Microsoft Core UI Components Dll:10.0.22621.2506:Microsoft Corporation DBGHELP.DLL:Windows Image Helper:10.0.22621.2506 (WinBuild.160101.0800):Microsoft Corporation DEVOBJ.dll:Device Information Set DLL:10.0.22621.2506 (WinBuild.160101.0800):Microsoft Corporation DNSAPI.dll:DNS Client API DLL:10.0.22621.1 (WinBuild.160101.0800):Microsoft Corporation GDI32.dll:GDI Client DLL:10.0.22621.3085 (WinBuild.160101.0800):Microsoft Corporation GLU32.dll:OpenGL Utility Library DLL:10.0.22621.1 (WinBuild.160101.0800):Microsoft Corporation IMM32.DLL:Multi-User Windows IMM32 API Client DLL:10.0.22621.2792 (WinBuild.160101.0800):Microsoft Corporation IPHLPAPI.DLL:IP Helper API:10.0.22621.1 (WinBuild.160101.0800):Microsoft Corporation KERNEL32.DLL:Windows NT BASE API Client DLL:10.0.22621.2506 (WinBuild.160101.0800):Microsoft Corporation KERNELBASE.dll:Windows NT BASE API Client DLL:10.0.22621.2506 (WinBuild.160101.0800):Microsoft Corporation MMDevApi.dll:MMDevice API:10.0.22621.1 (WinBuild.160101.0800):Microsoft Corporation MSCTF.dll:MSCTF Server DLL:10.0.22621.1 (WinBuild.160101.0800):Microsoft Corporation MpOav.dll:IOfficeAntiVirus Module:4.18.24020.7 (f5b7a53876c03330b0e7c1a6020590269cbbc2b6):Microsoft Corporation NSI.dll:NSI User-mode interface DLL:10.0.22621.1 (WinBuild.160101.0800):Microsoft Corporation NTASN1.dll:Microsoft ASN.1 API:10.0.22621.1 (WinBuild.160101.0800):Microsoft Corporation OLEAUT32.dll:OLEAUT32.DLL:10.0.22621.2506 (WinBuild.160101.0800):Microsoft Corporation Ole32.dll:Microsoft OLE for Windows:10.0.22621.1 (WinBuild.160101.0800):Microsoft Corporation OpenAL.dll:Main implementation library:1.23.0: POWRPROF.dll:Power Profile Helper DLL:10.0.22621.2506 (WinBuild.160101.0800):Microsoft Corporation PSAPI.DLL:Process Status Helper:10.0.22621.1 (WinBuild.160101.0800):Microsoft Corporation Pdh.dll:Windows Performance Data Helper DLL:10.0.22621.1 (WinBuild.160101.0800):Microsoft Corporation RPCRT4.dll:Remote Procedure Call Runtime:10.0.22621.2506 (WinBuild.160101.0800):Microsoft Corporation SETUPAPI.dll:Windows Setup API:10.0.22621.1 (WinBuild.160101.0800):Microsoft Corporation SHCORE.dll:SHCORE:10.0.22621.1 (WinBuild.160101.0800):Microsoft Corporation SHELL32.dll:Windows Shell Common Dll:10.0.22621.2792 (WinBuild.160101.0800):Microsoft Corporation UMPDC.dll:User Mode Power Dependency Coordinator:10.0.22621.1 (WinBuild.160101.0800):Microsoft Corporation USER32.dll:Multi-User Windows USER API Client DLL:10.0.22621.1 (WinBuild.160101.0800):Microsoft Corporation USERENV.dll:Userenv:10.0.22621.1 (WinBuild.160101.0800):Microsoft Corporation VCRUNTIME140.dll:Microsoft® C Runtime Library:14.16.27031.1 built by: vcwrkspc:Microsoft Corporation VERSION.dll:Version Checking and File Installation Libraries:10.0.22621.1 (WinBuild.160101.0800):Microsoft Corporation WINHTTP.dll:Windows HTTP Services:10.0.22621.1 (WinBuild.160101.0800):Microsoft Corporation WINMM.dll:MCI API DLL:10.0.22621.1 (WinBuild.160101.0800):Microsoft Corporation WINSTA.dll:Winstation Library:10.0.22621.2506 (WinBuild.160101.0800):Microsoft Corporation WINTRUST.dll:Microsoft Trust Verification APIs:10.0.22621.3085 (WinBuild.160101.0800):Microsoft Corporation WS2_32.dll:Windows Socket 2.0 32-Bit DLL:10.0.22621.1 (WinBuild.160101.0800):Microsoft Corporation WSOCK32.dll:Windows Socket 32-Bit DLL:10.0.22621.1 (WinBuild.160101.0800):Microsoft Corporation WTSAPI32.dll:Windows Remote Desktop Session Host Server SDK APIs:10.0.22621.1 (WinBuild.160101.0800):Microsoft Corporation amsi.dll:Anti-Malware Scan Interface:10.0.22621.1 (WinBuild.160101.0800):Microsoft Corporation apphelp.dll:Application Compatibility Client Library:10.0.22621.1 (WinBuild.160101.0800):Microsoft Corporation bcrypt.dll:Windows Cryptographic Primitives Library:10.0.22621.1 (WinBuild.160101.0800):Microsoft Corporation bcryptPrimitives.dll:Windows Cryptographic Primitives Library:10.0.22621.2506 (WinBuild.160101.0800):Microsoft Corporation cfgmgr32.dll:Configuration Manager DLL:10.0.22621.2506 (WinBuild.160101.0800):Microsoft Corporation clbcatq.dll:COM+ Configuration Catalog:2001.12.10941.16384 (WinBuild.160101.0800):Microsoft Corporation combase.dll:Microsoft COM for Windows:10.0.22621.1 (WinBuild.160101.0800):Microsoft Corporation cryptnet.dll:Crypto Network Related API:10.0.22621.1 (WinBuild.160101.0800):Microsoft Corporation dbgcore.DLL:Windows Core Debugging Helpers:10.0.22621.1 (WinBuild.160101.0800):Microsoft Corporation dhcpcsvc.DLL:DHCP Client Service:10.0.22621.1 (WinBuild.160101.0800):Microsoft Corporation dhcpcsvc6.DLL:DHCPv6 Client:10.0.22621.1 (WinBuild.160101.0800):Microsoft Corporation dinput8.dll:Microsoft DirectInput:10.0.22621.1 (WinBuild.160101.0800):Microsoft Corporation drvstore.dll:Driver Store API:10.0.22621.2506 (WinBuild.160101.0800):Microsoft Corporation dwmapi.dll:Microsoft Desktop Window Manager API:10.0.22621.1 (WinBuild.160101.0800):Microsoft Corporation dxcore.dll:DXCore:10.0.22621.3085 (WinBuild.160101.0800):Microsoft Corporation fastprox.dll:WMI Custom Marshaller:10.0.22621.2506 (WinBuild.160101.0800):Microsoft Corporation fwpuclnt.dll:FWP/IPsec User-Mode API:10.0.22621.2506 (WinBuild.160101.0800):Microsoft Corporation gdi32full.dll:GDI Client DLL:10.0.22621.3085 (WinBuild.160101.0800):Microsoft Corporation glfw.dll:GLFW 3.4.0 DLL:3.4.0:GLFW icm32.dll:Microsoft Color Management Module (CMM):10.0.22621.3085 (WinBuild.160101.0800):Microsoft Corporation inputhost.dll:InputHost:10.0.22621.2506 (WinBuild.160101.0800):Microsoft Corporation java.dll:OpenJDK Platform binary:17.0.8.1:Amazon.com Inc. javaw.exe:OpenJDK Platform binary:17.0.8.1:Amazon.com Inc. jemalloc.dll jimage.dll:OpenJDK Platform binary:17.0.8.1:Amazon.com Inc. jli.dll:OpenJDK Platform binary:17.0.8.1:Amazon.com Inc. jna16404202064027558787.dll:JNA native library:6.1.6:Java(TM) Native Access (JNA) jsvml.dll:OpenJDK Platform binary:17.0.8.1:Amazon.com Inc. jvm.dll:OpenJDK 64-Bit server VM:17.0.8.1:Amazon.com Inc. kernel.appcore.dll:AppModel API Host:10.0.22621.2715 (WinBuild.160101.0800):Microsoft Corporation lwjgl.dll lwjgl_opengl.dll lwjgl_stb.dll management.dll:OpenJDK Platform binary:17.0.8.1:Amazon.com Inc. management_ext.dll:OpenJDK Platform binary:17.0.8.1:Amazon.com Inc. msasn1.dll:ASN.1 Runtime APIs:10.0.22621.2506 (WinBuild.160101.0800):Microsoft Corporation mscms.dll:Microsoft Color Matching System DLL:10.0.22621.1 (WinBuild.160101.0800):Microsoft Corporation msvcp140.dll:Microsoft® C Runtime Library:14.16.27033.0 built by: vcwrkspc:Microsoft Corporation msvcp_win.dll:Microsoft® C Runtime Library:10.0.22621.2506 (WinBuild.160101.0800):Microsoft Corporation msvcrt.dll:Windows NT CRT DLL:7.0.22621.2506 (WinBuild.160101.0800):Microsoft Corporation mswsock.dll:Microsoft Windows Sockets 2.0 Service Provider:10.0.22621.1 (WinBuild.160101.0800):Microsoft Corporation napinsp.dll:E-mail Naming Shim Provider:10.0.22621.1 (WinBuild.160101.0800):Microsoft Corporation ncrypt.dll:Windows NCrypt Router:10.0.22621.1 (WinBuild.160101.0800):Microsoft Corporation net.dll:OpenJDK Platform binary:17.0.8.1:Amazon.com Inc. nio.dll:OpenJDK Platform binary:17.0.8.1:Amazon.com Inc. nlansp_c.dll:NLA Namespace Service Provider DLL:10.0.22621.2506 (WinBuild.160101.0800):Microsoft Corporation ntdll.dll:NT Layer DLL:10.0.22621.2506 (WinBuild.160101.0800):Microsoft Corporation ntmarta.dll:Windows NT MARTA provider:10.0.22621.1 (WinBuild.160101.0800):Microsoft Corporation nvoglv64.dll:NVIDIA Compatible OpenGL ICD:31.0.15.3758:NVIDIA Corporation nvspcap64.dll:NVIDIA Game Proxy:3.27.0.112:NVIDIA Corporation opengl32.dll:OpenGL Client DLL:10.0.22621.2506 (WinBuild.160101.0800):Microsoft Corporation perfos.dll:Windows System Performance Objects DLL:10.0.22621.1 (WinBuild.160101.0800):Microsoft Corporation pfclient.dll:SysMain Client:10.0.22621.1 (WinBuild.160101.0800):Microsoft Corporation pnrpnsp.dll:PNRP Name Space Provider:10.0.22621.1 (WinBuild.160101.0800):Microsoft Corporation profapi.dll:User Profile Basic API:10.0.22621.2506 (WinBuild.160101.0800):Microsoft Corporation rasadhlp.dll:Remote Access AutoDial Helper:10.0.22621.1 (WinBuild.160101.0800):Microsoft Corporation resourcepolicyclient.dll:Resource Policy Client:10.0.22621.1 (WinBuild.160101.0800):Microsoft Corporation rsaenh.dll:Microsoft Enhanced Cryptographic Provider:10.0.22621.1 (WinBuild.160101.0800):Microsoft Corporation sapi.dll:Speech API:5.3.26906.00 (WinBuild.160101.0800):Microsoft Corporation sechost.dll:Host for SCM/SDDL/LSA Lookup APIs:10.0.22621.1 (WinBuild.160101.0800):Microsoft Corporation shlwapi.dll:Shell Light-weight Utility Library:10.0.22621.1 (WinBuild.160101.0800):Microsoft Corporation sunmscapi.dll:OpenJDK Platform binary:17.0.8.1:Amazon.com Inc. textinputframework.dll:"TextInputFramework.DYNLINK":10.0.22621.3235 (WinBuild.160101.0800):Microsoft Corporation ucrtbase.dll:Microsoft® C Runtime Library:10.0.22621.2506 (WinBuild.160101.0800):Microsoft Corporation uxtheme.dll:Microsoft UxTheme Library:10.0.22621.1 (WinBuild.160101.0800):Microsoft Corporation verify.dll:OpenJDK Platform binary:17.0.8.1:Amazon.com Inc. wbemcomn.dll:WMI:10.0.22621.2506 (WinBuild.160101.0800):Microsoft Corporation wbemprox.dll:WMI:10.0.22621.3085 (WinBuild.160101.0800):Microsoft Corporation wbemsvc.dll:WMI:10.0.22621.3085 (WinBuild.160101.0800):Microsoft Corporation win32u.dll:Win32u:10.0.22621.3085 (WinBuild.160101.0800):Microsoft Corporation windows.storage.dll:Microsoft WinRT Storage API:10.0.22621.2506 (WinBuild.160101.0800):Microsoft Corporation winrnr.dll:LDAP RnR Provider DLL:10.0.22621.1 (WinBuild.160101.0800):Microsoft Corporation wintypes.dll:Windows Base Types DLL:10.0.22621.1 (WinBuild.160101.0800):Microsoft Corporation wldp.dll:Windows Lockdown Policy:10.0.22621.2506 (WinBuild.160101.0800):Microsoft Corporation wshbth.dll:Windows Sockets Helper DLL:10.0.22621.2506 (WinBuild.160101.0800):Microsoft Corporation wshunix.dll:AF_UNIX Winsock2 Helper DLL:10.0.22621.1 (WinBuild.160101.0800):Microsoft Corporation xinput1_4.dll:Microsoft Common Controller API:10.0.22621.1 (WinBuild.160101.0800):Microsoft Corporation zip.dll:OpenJDK Platform binary:17.0.8.1:Amazon.com Inc. Stacktrace: at net.minecraft.class_309.method_1474(class_309.java:514) at net.minecraft.class_310.method_1574(class_310.java:2004) at net.minecraft.class_310.method_1523(class_310.java:1237) at net.minecraft.class_310.method_1514(class_310.java:856) at net.minecraft.client.main.Main.main(Main.java:253) at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:470) at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74) at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)

-- Affected level -- Details: All players: 1 total; [class_746['Boxic'/117175, l='ClientLevel', x=121.53, y=7.00, z=127.99]] Chunk stats: 4096, 705 Level dimension: minecraft:overworld Level spawn location: World: (-37,52,-80), Section: (at 11,4,0 in -3,3,-5; chunk contains blocks -48,-64,-80 to -33,319,-65), Region: (-1,-1; contains chunks -32,-32 to -1,-1, blocks -512,-64,-512 to -1,319,-1) Level time: 911328498 game time, 6000 day time Server brand: Paper (Velocity) Server type: Non-integrated multiplayer server Stacktrace: at net.minecraft.class_638.method_8538(class_638.java:451) at net.minecraft.class_310.method_1587(class_310.java:2481) at net.minecraft.class_310.method_1514(class_310.java:875) at net.minecraft.client.main.Main.main(Main.java:253) at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:470) at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74) at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)

-- Last reload -- Details: Reload number: 1 Reload reason: initial Finished: Yes Packs: vanilla, fabric, file/Dev-ResourcePack

-- System Details -- Details: Minecraft Version: 1.20.2 Minecraft Version ID: 1.20.2 Operating System: Windows 11 (amd64) version 10.0 Java Version: 17.0.8.1, Amazon.com Inc. Java VM Version: OpenJDK 64-Bit Server VM (mixed mode, sharing), Amazon.com Inc. Memory: 283739112 bytes (270 MiB) / 883949568 bytes (843 MiB) up to 2147483648 bytes (2048 MiB) CPUs: 32 Processor Vendor: GenuineIntel Processor Name: 13th Gen Intel(R) Core(TM) i9-13900K Identifier: Intel64 Family 6 Model 183 Stepping 1 Microarchitecture: unknown Frequency (GHz): 3.00 Number of physical packages: 1 Number of physical CPUs: 24 Number of logical CPUs: 32 Graphics card #0 name: NVIDIA GeForce RTX 4090 Graphics card #0 vendor: NVIDIA (0x10de) Graphics card #0 VRAM (MB): 4095.00 Graphics card #0 deviceId: 0x2684 Graphics card #0 versionInfo: DriverVersion=31.0.15.3758 Memory slot #0 capacity (MB): 32768.00 Memory slot #0 clockSpeed (GHz): 6.00 Memory slot #0 type: Unknown Memory slot #1 capacity (MB): 32768.00 Memory slot #1 clockSpeed (GHz): 6.00 Memory slot #1 type: Unknown Virtual memory max (MB): 69372.99 Virtual memory used (MB): 28666.41 Swap memory total (MB): 4096.00 Swap memory used (MB): 0.00 JVM Flags: 2 total; -XX:HeapDumpPath=MojangTricksIntelDriversForPerformance_javaw.exe_minecraft.exe.heapdump -Xmx2048M JVM uptime in seconds: 96.526 Launched Version: 1.20.2 Backend library: LWJGL version 3.3.2-snapshot Backend API: NVIDIA GeForce RTX 4090/PCIe/SSE2 GL version 3.2.0 NVIDIA 537.58, NVIDIA Corporation Window size: 1920x1009 GL Caps: Using framebuffer using OpenGL 3.2 GL debug messages: Using VBOs: Yes Is Modded: Definitely; Client brand changed to 'fabric' Type: Client (map_client.txt) Graphics mode: fabulous Resource Packs: vanilla, fabric, file/Dev-ResourcePack Current Language: en_us Locale: en_US CPU: 32x 13th Gen Intel(R) Core(TM) i9-13900K

Felix14-v2 commented 7 months ago

Have you read this section of the Sodium Wiki?

boxic commented 7 months ago

Have you read this section of the Sodium Wiki?

I have now, does this mean this error won't be fixed?

douira commented 7 months ago

To be clear, the reason Sodium doesn't support core shaders is because doing so is impossible.

boxic commented 7 months ago

Well, if it's a non-issue then so be it. However, if there's a way to support it, here's more information that might be helpful. Otherwise, thanks for taking a look at it. image

Felix14-v2 commented 7 months ago

I have now, does this mean this error won't be fixed?

Not from the Sodium side. Yeah, if you are a pack developer, there's a solution for you, but I can't say if it's good or bad.

boxic commented 7 months ago

I have now, does this mean this error won't be fixed?

Not from the Sodium side. Yeah, if you are a pack developer, there's a solution for you, but I can't say if it's good or bad.

Hmm, requiring the playerbase to install a custom mod for 1 block texture effect is just too big of an ask for me, I reckon I'm better off being thankful that the rest of our effects seem to work fine, and just re-design this one.

Felix14-v2 commented 7 months ago

requiring the playerbase to install a custom mod for 1 block texture effect is just too big of an ask for me

Well, you should be prepared for compromises when using such invasive performance mods like Sodium. Its insane performance wouldn't be possible without compromises like that.