search

CaffeineMC / sodium

A Minecraft mod designed to improve frame rates and reduce micro-stutter
Other
4.78k stars 812 forks source link

Vignette option controls both darkness vignette and world border redness #2457

Open muzikbike opened 6 months ago

muzikbike commented 6 months ago

Request Description

The "Vignette" option in Video Settings only mentions the darkness screen edges effect, but this option also controls whether a red boundary is shown around the screen when close to the world border.

Either the redness should have a separate toggle, or the description should be changed to indicate that it also controls the world border effect.

2024-05-03_00 08 25 2024-05-03_00 10 04

douira commented 6 months ago

related: https://github.com/CaffeineMC/sodium-fabric/issues/2415

jellysquid3 commented 5 months ago

Truthfully, there is not much reason for the option to even be there, given it's a cosmetic tweak and doesn't affect performance...

Lolothepro commented 5 months ago

Sodium's behavior is the same as in Minecraft Vanilla iirc

muzikbike commented 5 months ago

Worth noting there's two reports about this already: https://bugs.mojang.com/browse/MC-54988 https://bugs.mojang.com/browse/MC-241321

The fact that vanilla's option even toggles these directly contradicts a statement by Dinnerbone saying that Fast/Fancy's only difference should be leaves transparency and weather effects.