CaffeineMC / sodium

A Minecraft mod designed to improve frame rates and reduce micro-stutter
Other
4.81k stars 811 forks source link

Fix redness near light sources in dark areas when subject to Night Vision #2473

Open muzikbike opened 6 months ago

muzikbike commented 6 months ago

Request Description

Vanilla issue https://bugs.mojang.com/browse/MC-199559, which was presumably resolved for a period of time as https://bugs.mojang.com/browse/MC-58177 but reappeared swiftly afterwards and has persisted since.

This redness should not exist - I'd presume that block light shouldn't be visible in the first place if Night Vision is active since it should make everywhere visibly fully lit anyway. 2024-05-05_20 53 45

jellysquid3 commented 6 months ago

I'm of the opinion that Night Vision looks terrible because of this problem and others like it... but I don't know if it'd be well received by other people if we were to change it.

mrjasonn commented 6 months ago

I'm of the opinion that Night Vision looks terrible because of this problem and others like it... but I don't know if it'd be well received by other people if we were to change it.

If bedrock edition doesn't have this problem, then it would probably be more easily considerable to fix it in my opinion

muzikbike commented 6 months ago

Since vanilla presumably already fixed this at one point before it broke again it probably wouldn't be much of a problem to most people.