Closed douira closed 1 month ago
It's a good idea but it doesn't work with AUTO gui scale, there is no vertical scrolling and the extra line renders outside the screen now.
That's a good point, do you know where one makes the control element notify the GUI system of it's correct size? Is there a place where it calculates the total size of the GUI for determining the scale?
I've updated it to be only one line but truncate the width of the label dynamically based on the slider's value width.
LGTM
resolved conflicts and brought the branch up to speed with dev
This is fine as a temporary solution for now. But I wouldn't want to keep around multi-line controls once we rework the video setting screen.
This PR doesn't add it as a multiline option (anymore), I replaced it with label truncation.
My bad for not updating the description
As a compromise, this adds a fullscreen resolution slider but truncates the label to fit into one line. The design can be refined later, but at least users won't have to go to the vanilla settings for this now. Thanks to @MeeniMc for their previous work in https://github.com/CaffeineMC/sodium-fabric/pull/2296 on adding the option in the first place. I added the two-line functionality and changed the style. related: https://github.com/CaffeineMC/sodium-fabric/issues/46 Closes https://github.com/CaffeineMC/sodium-fabric/issues/2692