Closed douira closed 2 months ago
Would it make sense to remove the TS option from settings now, rather than later?
I don't know if a setting is necessary. If we don't have to have it, we should remove it before release. Maybe keeping it as a setting in the config file only is enough. However, for debugging TS issues it's helpful if it can be disabled as a comparison. Then again, we can also send them a build with the setting and/or it disabled by default.
I think we'll get rid of it (or put it behind a developer option) before release. But it's not relevant for this pull request.
VertexRange
as since the introduction of the translucency sorting system its firstoffset
field wasn't getting used anymore. It can simply be calculated on the fly as a prefix sum. Currently missing vertex ranges are replicated as-1
lengths which are distinct from a length of zero. I don't know if this is actually necessary or if we can just use a zero length as the default.isTranslucent
method on terrain render passes and materials instead of checking equalityfloatToComparableInt
to actually be correct, it doesn't seem to have been correct previously.