search

CaffeineMC / sodium

A Minecraft mod designed to improve frame rates and reduce micro-stutter
Other
4.77k stars 811 forks source link

No Error Contexts are not implemented for NeoForge #2671

Open mrmangohands opened 2 months ago

mrmangohands commented 2 months ago

Bug Description

The mixin in core/WindowMixin was updated and commented out during the multiloader merge, may need further changes https://github.com/CaffeineMC/sodium-fabric/blob/acb25b4e10961dd5ad0149e6fe6536519cc8d521/common/src/main/java/net/caffeinemc/mods/sodium/mixin/core/WindowMixin.java#L13

IMS212 commented 2 months ago

This was disabled due to the weirdness surrounding NeoForge's early window, and the fact that a separate path needs to be used there. I can work on this later.

jellysquid3 commented 2 months ago

We probably can't get this fixed in a reasonable time window for Sodium 0.6, since NeoForge complicates things with their early window initialization. The important thing is making sure that our Fabric builds still have this functionality.

IMS212 commented 2 months ago

I have already fixed Fabric support in https://github.com/CaffeineMC/sodium-fabric/commit/1744347c6d31dbef49fd2ba7d4373ef9efbe39cf.

jellysquid3 commented 1 month ago

This is not solvable without changes in NeoForge, since they clear the context bits and do not give mods any way to change the context initialization behavior.