search

CaffeineMC / sodium

A Minecraft mod designed to improve frame rates and reduce micro-stutter
Other
4.77k stars 811 forks source link

Fix compiler warnings #2687

Closed mrmangohands closed 5 hours ago

mrmangohands commented 2 months ago

The common project includes Sodium's Fabric API integration, which can be used on either loader. The Fabric API modules reference Fabric Loader's API classes, so we need to include it to prevent warning spam about an unknown enum constant.

This PR also splits out the remaining platform specific code from common, and adds remap = false where necessary to fix warnings.

douira commented 4 days ago

Have the review concerns been resolved? Also this needs to have its conflicts resolved

jellysquid3 commented 5 hours ago

Resolved with https://github.com/CaffeineMC/sodium/commit/dc7dc4c634316ac8b510d2dc8290079ebc462778. Thanks!