Fabulous!: Water is not rendered behind some XyCraft items

CaffeineMC / sodium

A Minecraft mod designed to improve frame rates and reduce micro-stutter

Other

4.77k stars 811 forks source link

Fabulous!: Water is not rendered behind some XyCraft items #2705

Open Lolothepro opened 2 months ago

Lolothepro commented 2 months ago

Bug Description

Water is rendered behind certain XyCraft items

2024-08-23_20 31 17

Example with XyCraft Machines (Power Core)

Reproduction Steps

Place a “Power Core” close to the water See the bug

Log File

https://mclo.gs/avK4QJV

Crash Report

jellysquid3 commented 2 months ago

Does this not also happen in Vanilla? I don't see why our mod would affect this. You would need to use Fabulous mode to fix it.

Lolothepro commented 2 months ago

Does this not also happen in Vanilla? I don't see why our mod would affect this. You would need to use Fabulous mode to fix it.

Only with Sodium+Fabulous!

Lolothepro commented 2 months ago

https://discord.com/channels/602796788608401408/1260082015479271535/1260662475771215987

IMS212 commented 2 months ago

This bug has a very simple cause; Sodium runs runChunkLayerEvents after clearRenderState has been called, because the former requires a lot of Vanilla state passed through. This is usually fine, but in Fabulous, this means it's no longer drawing to the correct framebuffer.