CaffeineMC / sodium

A Minecraft mod designed to improve frame rates and reduce micro-stutter
Other
4.77k stars 811 forks source link

ResolutionControl 3 regression in 0.6.0-beta.1 #2712

Closed xirreal closed 2 months ago

xirreal commented 2 months ago

Bug Description

Image scaling does not work on beta-1, while it worked fine on alpha-3. Tested in a minimal environment (sodium, modmenu, resolution control 3 and fapi) beta-1: beta-1 alpha-3: alpha-3

Reproduction Steps

  1. Install mods
  2. Change resolution scale in mod menu

Log File

alpha-3 log beta-1 log

Crash Report

forced crash alpha-3 forced crash beta-1

IMS212 commented 2 months ago

This is caused by RC3 (ab)using the blit shader to get it's scaling done via textures. The new hardware blit code doesn't provide this.

IMS212 commented 2 months ago

I have contacted the RC3 dev; an easy workaround will be enabling the shader at all times, but it's in their best interest to fix it on their side as 1.21.2 will have the same issue.

pajicadvance commented 2 months ago

Mod just got updated with a fix for this issue.