Face culling no longer works between blocks of different render types

CaffeineMC / sodium

A Minecraft mod designed to improve frame rates and reduce micro-stutter

Other

4.81k stars 810 forks source link

Face culling no longer works between blocks of different render types #2850

Closed muzikbike closed 1 week ago

muzikbike commented 3 weeks ago

Bug Description

In the latest Sodium betas, cutout, cutout_mipped and translucent blocks do not get culled at all by solid blocks, which is obviously a bad thing since some faces are getting pointlessly rendered now. 2024-10-29_13 16 04 2024-10-29_13 16 11

Reproduction Steps

Place an affected transparent block of your choice on the floor
Enter Spectator mode
Clip into the floor and observe

Log File

latest.log

Crash Report

crash-2024-10-29_13.20.21-client.txt

jellysquid3 commented 3 weeks ago

Do you know which version this was regressed? It would be helpful to have a bisect.

muzikbike commented 3 weeks ago

The issue appears to have first arisen in beta 3 and was not present in beta 1 or 2.

jellysquid3 commented 1 week ago

This only seems to happen in Minecraft 1.21.3, and works correctly in Minecraft 1.21.1.

jellysquid3 commented 1 week ago

The commit https://github.com/CaffeineMC/sodium/commit/990cf64885b50d0180a243328a2c28d5c7c4cfb2 fixes this problem and will be made part of the next release.