search

Cagation / quickb2

Automatically exported from code.google.com/p/quickb2
0 stars 0 forks source link

Follow common naming conventions in AS3 #19

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
This is a non-functional issue i stumble upon each time i re-visit your 
otherwise very good library.

Your packages begin with upper-case letters and you classes with lower-case 
letters.

I know you probably have other things on your mind, but it just looks soo 
awkward in the AS3 world.

Original issue reported on code.google.com by sven.bu...@gmail.com on 10 Feb 2011 at 4:29

GoogleCodeExporter commented 9 years ago 
Just depends on what you're used to I guess.  That style of class prefix is a 
pretty common convention for mitigating naming conflicts.  As for the packages, 
are you suggesting "quickb2.objects.tangibles.qb2Body" instead of 
"QuickB2.objects.tangibles.qb2Body".  That change isn't such a big deal if it's 
enough of an issue for people.

Thank you for your feedback, and I apologize for taking some time to get back 
to you...I thought I had it set up to automatically notify me of new issues.

Original comment by doug...@gmail.com on 20 Feb 2011 at 12:05

GoogleCodeExporter commented 9 years ago 
Hi,

thanks for commenting. I'm OK with having prefixes, but i think, the common 
convention in AS3 (opposed to C++, as it seems) is, that classes always begin 
with a capital letter and packages always with a lower-case letter. So i think, 
i would propose:

quickb2.objects.tangibles.QB2Body

On the other hand, i understand that this would break compatibility with your 
complete current API, so probably it is best to keep it like it is.

I recognize, that the flash port of box2d is following the same C++ style 
conventions.

Original comment by sven.bu...@gmail.com on 20 Feb 2011 at 11:34