search

Cahu / krpc-hs

A Haskell client for kRPC
GNU General Public License v3.0
12 stars 2 forks source link

Nulls are not handled correctly #6

Open Shimuuar opened 7 years ago

Shimuuar commented 7 years ago

For example getPartFairing returns null if part is not actually fairing. So getPairFairing should return Maybe Fairing instead it return Fairing {fairingId = 0}

Cahu commented 7 years ago

The 'null' possibility is not specified in the service definition files so there's no way for the code generator to produce the correct code for these functions. This doesn't seem to be encoded in the new format used in krpc4 either.

I opened an issue https://github.com/krpc/krpc/issues/395.