search

CaiJimmy / hugo-theme-stack

Card-style Hugo theme designed for bloggers
https://stack.jimmycai.com
GNU General Public License v3.0
4.82k stars 1.55k forks source link

Disqus comments threads not being displayed #1041

Closed arthur1041 closed 1 week ago

arthur1041 commented 1 month ago

What happened?

Bug report

Disqus comments thread is not being displayed even after being correctly configured within the config.yaml file.

image

Potential solution

I managed to fix it by copying the content from within themes/theme-stack/layouts/partials/comments/provider/disqusjs.html and pasting it inside themes/theme-stack/layouts/partials/comments/provider/disqus.html. Now it works fine:

image

Hugo version

v0.130.0+extended

Theme version

3.26.0

What browsers are you seeing the problem on?

Chrome

More information about the browser

No response

Relevant log output

No response

Link to Minimal Reproducible Example

https://github.com/CaiJimmy/hugo-theme-stack/blob/master/layouts/partials/comments/provider/disqus.html ->(my published website doesn't have the error anymore since I fixed it locally)

arthur1041 commented 3 weeks ago

Hey, @CaiJimmy. Can you review this PR, please?

CaiJimmy commented 1 week ago

Hi Arthur, thanks for the issue report and the pull request. However, I cannot reproduce this issue locally or online. The demo site is built with the latest version of Hugo (0.134.1) and the Disqus comment works fine.

I cannot accept your pull request because it replaces Disqus with Disqus.js, which is a third-party solution that is completely different and requires more setup.

I would guess that your Disqus comment is not showing due to a wrong configuration (e.g. wrong Disqus site name).

Feel free to reopen this issue if you are able to reproduce this problem online.

MuenYu commented 5 days ago

@arthur1041 You should put the pagenation part at the bottom of the config.toml file. like this