CaiJimmy / hugo-theme-stack

Card-style Hugo theme designed for bloggers
https://stack.jimmycai.com
GNU General Public License v3.0
5.06k stars 1.66k forks source link

[Bug]: Remark42 comment system won't show #800

Closed jkcharlie6679 closed 1 year ago

jkcharlie6679 commented 1 year ago

What happened?

I found that when I import the remark42 comment system, it won't show on the page. According to the remark42 official page, the code needs to add !.

like:

<script>!function(e,n){for(var o=0;o<e.length;o++){var r=n.createElement("script"),c=".js",d=n.head||n.body;"noModule"in r?(r.type="module",c=".mjs"):r.async=!0,r.defer=!0,r.src=remark_config.host+"/web/"+e[o]+c,d.appendChild(r)}}(remark_config.components||["embed"],document);</script>

Hugo version

0.107.0

Theme version

3.16.0

What browsers are you seeing the problem on?

Microsoft Edge

More information about the browser

No response

Relevant log output

No response

Link to the page with bug

https://demo.stack.jimmycai.com

Link to the source repository

No response

jkcharlie6679 commented 1 year ago

I have fixed it and pushed a pull request. If @CaiJimmy you feel it is correct, please help me to merge it. Please let me know if I need to do anything about this bug. Thank you.